[HOLD for #318] [$250] iOS - Single emoji is not enlarged on iOS

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to chat.
3. Open emoji picker,
4. Insert one emoji.

Expected Result:

The emoji will appear enlarged when only emoji is present in the composer.

Actual Result:

The emoji is not larged and there is an empty line above it. It only is enlarged when the space behind the emoji is removed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467473_1714543809903.iOS_emoji.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e913a46985dfa7d8
• Upwork Job ID: 1788661557931286528
• Last Price Increase: 2024-05-09
• Automatic offers:
• hoangzinh | Reviewer | 0

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

RPReplay_Final1714548300.MP4

[francoisl]

I wonder if it comes from #40617 - testing an ad-hoc build of a revert in here.

[youssef-lr]

Tested the PR and can still reproduce. Checking other suspicious PRs now.

[youssef-lr]

@robertKozik @Ollyws this PR has caused this issue, can you guys take a look please?

[francoisl]

Looks like there was also an issue on web reported in this comment for that PR. No need to block the deploy on this, we can treat it as a follow-up fix.

[Christinadobrzyn]

@robertKozik @Ollyws this #41027 has caused this issue, can you guys take a look please?

[melvin-bot]

@youssef-lr, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[youssef-lr]

friendly bump @robertKozik @Ollyws

[Ollyws]

I don't think this was caused by #41027, the issue with the emoji not being enlarged when added was happening before:

Screen.Recording.2024-05-07.at.09.54.01.mov

[filip-solecki]

Hi!
I am Filip from SWM and I'd like to work on this issue!

[melvin-bot]

@hoangzinh @youssef-lr @Christinadobrzyn this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Christinadobrzyn]

Thank you @filip-solecki! I added you to this GH.

[filip-solecki]

Hi, looks like it is partially known issue that iOS devices are one step back with the composer and this is why the emoji is not enlarged. I think we should wait until this PR to live markdown will be merged and then we will recheck this issue.

[Christinadobrzyn]

Thank @filip-solecki! We'll hold for Expensify/react-native-live-markdown#318

[Christinadobrzyn]

I think I'll keep this daily but keep an eye on Expensify/react-native-live-markdown#318

[Christinadobrzyn]

watching - Expensify/react-native-live-markdown#318

[Christinadobrzyn]

watching - Expensify/react-native-live-markdown#318 - gonna move this to weekly since the PR merge is still in the works

[Christinadobrzyn]

watching - Expensify/react-native-live-markdown#318

[Christinadobrzyn]

looks like this is still happening.

@filip-solecki do you think we should still keep this on hold for Expensify/react-native-live-markdown#318

[filip-solecki]

Yes, we've tried to upgrade Markdown version here but it was reverted, so I think soon there should be another try and this issue should disappear.

[Christinadobrzyn]

Thanks for the update @filip-solecki!

Just a heads up - I'm going to be ooo until June 24th. I'm not going to assign anyone new but if you need a new BZ teammate for any reason please feel free to ask for one to be assigned here.

[BartoszGrajdek]

The bump went through, so we should be ready to get this retested!

[kavimuru]

Bug is fixed

RPReplay_Final1718716866.MP4

[Christinadobrzyn]

Bug is fixed

Amazing! I think that means we can close this? @filip-solecki @BartoszGrajdek

[BartoszGrajdek]

Yes we can! :)