[HOLD for Payment: 2024-05-15] Expense Report - Top and bottom borders of "Next step" are cut off when the text has one line

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Create a new workspace.
3. Go to workspace settings > Workflows.
4. Tap Submission frequency.
5. Tap Manually.
6. Go to workspace chat.
7. Create a manual request.
8. Go to expense report.

Expected Result:

The "Next step" top and bottom borders will not be cut off.

Actual Result:

The "Next step" top and bottom borders are cut off. This only happens when "Next step" message has only one line.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6468033_1714574764545.RPReplay_Final1714573567.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[cretadn22]

Offending PR: #38471

[francoisl]

Ok, this sounds like a polishing issue and not a real blocker.

cc @dragnoir if you could take a look please.

[dragnoir]

ok checking..

[dragnoir]

PR ready #41643

[ikevin127]

⚠️ Automation failed -> this should be on [HOLD for Payment [2024-05-15]] according to today's production deploy from #41643 (comment).

cc @francoisl @dylanexpensify

[dylanexpensify]

@ikevin127 thanks, will update!

[ikevin127]

@dylanexpensify Is anything else needed from my side in order for the payment to be issued today ?

[dylanexpensify]

Payment summary:

• Contributor: @ikevin127 $250
• Contributor+: @dragnoir $250

Please apply!

[dragnoir]

Done, thank you

[ikevin127]

@dylanexpensify Applied: https://www.upwork.com/ab/proposals/1791197920848183297. Thank you!

Edit: Accepted offer!

[dylanexpensify]

All done!