[HOLD for payment 2024-06-28] Clean up workspace avatars display logic

[grgia]

Follow up issue for tracking @Kicu

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[grgia]

Mind linking the original PR when you comment so I can assign @Kicu

[Kicu]

After quickfix is merged then I will do some improvement on the avatars code.

this was the PR that caused the original bugs: #39637
this is the quickfix (not yet merged): #41485

[melvin-bot]

@Kicu, @Pujan92, @grgia Huh... This is 4 days overdue. Who can take care of this?

[grgia]

@Kicu mind sending an update on this?

[Kicu]

Well there is no updated on this since I haven't started to work on this yet.
First this: #41485 and #41846 need to be merged (and in that order).

After both are merged I can work on this task.

[melvin-bot]

@Kicu, @Pujan92, @grgia Eep! 4 days overdue now. Issues have feelings too...

[Kicu]

This is dragging on because of the merge freeze and still awaiting on #41846

This is also mostly cleaning up avatar logic and making the code easier to work with in future. So I think there is no rush. I will keep tabs on this

[melvin-bot]

@Kicu, @Pujan92, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Kicu]

Still awaiting merge of #41846

[melvin-bot]

@Kicu, @Pujan92, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

@abekkala could you help with $250 C+ review payment to @Pujan92?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make <Avatar> related code more consistent #43366

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR JUNE 24

• Fix: @Kicu - SWM - no payment required
• PR Review: @s77rt [$250, pending no regressions] payment via NewDot
  please complete checklist

[s77rt]

@abekkala This is a cleanup issue only. No checklist is needed and no payment is due (payment is handled in parent issue). We can close this one

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make <Avatar> related code more consistent #43366

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist #41912 (comment)

[abekkala]

No overdue MELVIN! payment is set for Jun 28

[abekkala]

PAYMENT SUMMARY FOR JUNE 28

• Fix: @Kicu - SWM - no payment required
• PR Review: @s77rt [$250] payment via NewDot

[s77rt]

Payment is handled on the parent issue since this is a clean up issue only.