[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Travel] [Refactor] Create a new shared component for AddressPage

[mountiny]

Problem

Currently WorkspaceProfileAddressPage and AddressPage have some repeated code (ex. handleAddressChange callback, useEffect on countryFromUrl or useEffect on address)

Moreover, AddressPage has code which has no effect - ex. useEffect on stateFromUrl (because stateFromUrl is always undefined).

Those code readability issues were detected while creating and reviewing WorkspaceProfilePage PR ex. here or here.

Solution

We should create a new component as a middle layer between AddressPage/WorkspaceProfileAddressPage and AddressForm. Current AddressPage should be renamed to PersonalAddressPage and the new component should be named AddressPage.

New AddressPage should contain all the common logic for PersonalAddressPage and WorkspaceAddressPage.

WorkspaceAddressPage and PersonalAddressPage should only contain logic behind callbacks to API.
Those are rather simple changes which should improve code readability and make it easier to maintain.

Issue Owner

Current Issue Owner: @slafortune / @joekaufmanexpensify

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[smelaa]

Hi, I am Aleksandra Smela from SWM and I would like to work on this issue!

[dubielzyk-expensify]

I've been assigned as a design reviewer. Would you like me to have a look at this PR now or is it still too early?

[mountiny]

I dont think this should have any change in design so maybe its not required and you can unassign. Its automated as its a new feature.

The code changes should be unnoticed in product, purely code readability

[slafortune]

Looks like changes in the PR have been approved and it's moving forward! I'll be on vacation until June 4th, so adding another BZ in the meantime.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[mountiny]

Asked to get this PR merged

[getusha]

@mountiny could you assign me here? thanks

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[nkdengineer]

@mateuuszzzzz There was this proposal that fixes the regression, in case it's helpful to you.

[zfurtak]

Hello there :) If it's okay, from now I will be working on this issue instead of @mateuuszzzzz as recently he's had a lot stuff to do with Hybrid app.

[slafortune]

@zfurtak @mateuuszzzzz was there a conversation about this somewhere you can link here?

[zfurtak]

Oh sorry for confusion, there's no conversation to link, but I'm working for Software Mansion Agency and internally we decided to change the maintainer of this task.
I will look into it today or tomorrow.

[mountiny]

@slafortune I think this is fine for SWM to distribute internally. I will assign @zfurtak to this issue now

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Travel] Bring back refactored AddressPage #43348

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @mateuuszzzzz does not require payment (Contractor)
• @getusha requires payment through NewDot Manual Requests
• @zfurtak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

There is one sneaky regression but I think its really hard to catch in this flow so I suggest a normal $250 to @getusha and we can close this issue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Travel] Bring back refactored AddressPage #43348

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @mateuuszzzzz does not require payment (Contractor)
• @getusha requires payment through NewDot Manual Requests
• @zfurtak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[slafortune]

Based on this comment
@getusha is due for the C+ role $250 via newdot 👍
@zfurtak and @mateuuszzzzz are expert contributors and not due payment.

[JmillsExpensify]

$250 approved for @getusha