[$500] Waiting for you to add a bank account appears after adding deposit only bank account in OldDot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: yes
Reproducible in production?: Can't check, requires real credentials
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mattmoore
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715610623341999

Action Performed:

1. Create an expense report as an employee and submit
2. Have it approved on a New Expensify workspace chat and Pay with expensify
3. Go to OldDot and add a deposit only account
4. Return to the expense report on New Expensify
5. The add bank account button should't be there

Great comment here outlining what might be wrong here.

Expected Result:

The add bank account button shouldn't be there

Actual Result:

The add bank account button still there and refreshing the page doesn't help

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5f3ad3418d9fb9d
• Upwork Job ID: 1791214044572852224
• Last Price Increase: 2024-06-07

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

I will triage this tomorrow.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5f3ad3418d9fb9d

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[sakluger]

I triaged and added the External label, but I will also be OOO through May 31. @adelekennedy can you please manage the issue until then? Thanks!

[melvin-bot]

@sakluger, @ikevin127, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

waiting for proposals!

[ikevin127]

Overdue notes: Looking for proposals, bumped in #expensify-open-source Slack.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

Still waiting for proposals here!

[tgolen]

OK, I think I found what needs to happen for this to get fixed.

When a bank account is created on NewDot, there are Onyx updates created from web-expensify here.

When a bank account is created on OldDot, there are no Onyx updates created from web-secure here.

Here is the real kicker... we have no code in Web-Secure to build or send out Onyx updates 😦 . That will require a lot of code being copied to Web-Secure in order to support this flow.

[tgolen]

Probably the quickest way to make this happen would be to have the Web-Secure API make a request over to the Web-Expensify API which will compile the bank account list Onyx update and send it out with a pusher event.

@nkuoch @iwiznia I'm curious to hear what you think about this approach.

[iwiznia]

No good answers here... on one hand doing what you propose is adding more complexity, on the other we are not going to copy all the code related to onyx updates and pusher to web-s.

There's another option, which would be to move the API method from secure to web, would that be a huge effort or simple? Remember that web-s was a mistake and is not really needed and we will eventually deprecate it, so moving things to web will need to happen sooner or later.

[tgolen]

I briefly thought about moving the entire API command to Web-E, and I'm not sure if the frontend of web-secure is setup to call commands on both the web-e or the web-s API endpoint (at first glance, it doesn't look like there is any setup for doing this ref). I also have been discussing in slack and in person if this issue is really worth doing anything about. The workaround for me seems adequate: after adding your bank account on OldDot, go to the wallet page in NewDot and your new bank account will sync.

[iwiznia]

The right solution would be to move it, so my vote is we either we do that or do nothing since I agree the bug is quite minor.

[garrettmknight]

Also discussing alternatives in this thread

[nkuoch]

I agree that if we do something, we should move everything from secure to web about the vbba flow. But that might not be super fast to do, and maybe not worth spending time on oldDot when newDot is the new thing.

What we could do though is to create a web api sendBankAccountOnyxUpdates and call it from secure.
Should be easy enough? Or we could also do nothing as the bug is minor.

[tgolen]

OK, thanks! I was just talking with @garrettmknight and this is where we landed. I'm going to add a simple log to web-secure when someone adds a vbba and they have tryNewDot.classicRedirect.dismissed === false. Then, I'll followup after a month to check the logs to see how many people are trying to do this flow. If it's low, we can continue to do nothing. Otherwise, we try to come up with some better alternative.

[tgolen]

Daily Update

• I created a Web-S PR for this
• I created a followup issue to check the logs in a month

Next Steps

• @grgia Review and merge the PR

ETA

• Merged today, Aug 22

[tgolen]

This was deployed and can be closed.

[tgolen]

Update

• When I checked the logs today, I found that there were 44 instances of the log being triggered in the last two weeks.
• This seems like a significant amount that we should ideally do something with.
• I think the best solution here is to move the command from Web-S to Web-E and then have Web-E create the proper onyx updates to send to the frontend when a bank account is created on OldDot

Next Steps

• @tgolen reopen this issue and start looking into moving the command

ETA

• Friday, Oct. 4

[tgolen]

Daily Update

• I've created a Web-E PR that adds a new API command, copied from Web-S to create the bank account and send out Onyx updates to the user
• I've created a Web-S PR which calls the new Web-E API command and removes the old code

Next Steps

• @MonilBhavsar Review and merge the Web-E PR
• Once the Web-E PR is deployed to production, I will take the Web-S PR off HOLD

ETA

• Wednesday, Sep 25

[tgolen]

Daily Update

• The Web-E PR was reviewed
• I've responded to the reviews and pushed up changes to the PR

Next Steps

• @MonilBhavsar Continue to review and then merge the PR
• Once the Web-E PR is deployed to production, I will take the Web-S PR off HOLD

ETA

• Wednesday, Sep 25

[tgolen]

Daily Update

• The Web-E PR was merged and deployed to staging

Next Steps

• @tgolen Wait for the Web-E PR to be deployed to production, then take the Web-S PR off HOLD
• Get the Web-S PR reviewed and merged

ETA

• Friday, Sep 27

[tgolen]

Daily Update

• The Web-E PR was deployed to production
• The Web-S PR was taken off hold and merged

Next Steps

• Wait for the Web-S PR to deploy to production and then close this out

ETA

• Thursday, Sep 26

[tgolen]

The final PR was deployed to production yesterday so I am going to close this out.