[$250] Workspace - "[Onyx] Provided collection" console errors appear after creating a WS

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.74.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41651

Action Performed:

1. Log in with a new expensifail account in Chrome incognito mode
2. Open Chrome console
3. Create a workspace
4. Navigate to any of the default workspace rooms

Expected Result:

No console errors should appear

Actual Result:

"Expensify.tsx:43 [Onyx] Provided collection doesn't have all its data belonging to the same parent." console errors appear after creating a WS. Sometimes the errors appear after a few seconds, sometimes it takes 1-2 minutes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481631_1715778347799.bandicam_2024-05-15_14-59-11-002.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ddfbda5cc9dce3a
• Upwork Job ID: 1792511092144250880
• Last Price Increase: 2024-05-20

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[MitchExpensify]

Same error solved here https://expensify.slack.com/archives/C049HHMV9SM/p1689120594593919

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ddfbda5cc9dce3a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[mountiny]

Can you please help identify what response from the OpenReport is causing this error @shubham1206agra?

Seems like some of the onyx data might be malformed

[shubham1206agra]

I am not able to repro this.

[mountiny]

I think this is related to this PR https://github.com/Expensify/Auth/pull/10090 that was deployed for a bit.

it causes reports to be duplicated in the mergeCollection call but one set of reports is incorrectly added with 0,1,2,.. indices.

That as a consequence and the mergeCollection as a whole is not applied cc @jasperhuangg

Thats because here, we are going to mark the entire update as malformed and none of the reports from the mergeCollection will get merged into onyx.

[jasperhuangg]

Thank you @mountiny for looking into it. I didn't realize that mergeCollection worked like this and should have been more careful when adding the changes.

The incorrect indices were not intended to be on production at all–a Web PR that was held on the Auth PR was meant to go out shortly afterwards, but was held up on the merge freeze.

[mountiny]

This is hard to catch, no problem