Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Guided Setup Stage 3] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM #42321

Closed
1 of 6 tasks
m-natarajan opened this issue May 16, 2024 · 46 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented May 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.74-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715814647719679

Action Performed:

  1. Log in as user A in public domain
  2. Click FAB and select "Submit Expense"
  3. Enter amount and enter any email address with which no expensify account exists (user has access to the email inbox)
  4. Look for the email from user A
  5. Click "Pay" from the new user email

Expected Result:

That user is then taken to the chat report
image

Actual Result:

User is taken to the DM deeplinked to the IOU preview

image

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

upgradePath.mp4
Recording.77.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012fae825a3d74577c
  • Upwork Job ID: 1792806639199625216
  • Last Price Increase: 2024-05-21
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Christinadobrzyn
Copy link
Contributor

Hum... I'm not getting the IOU email for some reason - nor is the IOU loading in the User B account- I think there might be delays

@Christinadobrzyn
Copy link
Contributor

Asking for some guidance on how to create the IOU - https://expensify.slack.com/archives/C049HHMV9SM/p1716187149930759?thread_ts=1715814647.719679&cid=C049HHMV9SM

I'm not getting these emails

@Christinadobrzyn
Copy link
Contributor

OP is updated and this is reproducible - I think this can be external?

@Christinadobrzyn Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label May 21, 2024
Copy link

melvin-bot bot commented May 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012fae825a3d74577c

@melvin-bot melvin-bot bot changed the title Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM [$250] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM May 21, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 21, 2024
Copy link

melvin-bot bot commented May 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@b4s36t4
Copy link
Contributor

b4s36t4 commented May 21, 2024

I'm not sure weather this can be external as email templates are sent via backend. The link attached to Pay button is linked to IOU report we need to update the email template to link the DM report.

@Christinadobrzyn
Copy link
Contributor

ah good catch @b4s36t4 - thank you for reviewing that. Going to make this internal

@Christinadobrzyn Christinadobrzyn added Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with and removed External Added to denote the issue can be worked on by a contributor labels May 22, 2024
Copy link

melvin-bot bot commented May 22, 2024

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 23, 2024

original discussion here

Looks like this is due for Summer (August) so adding medium priority

@Christinadobrzyn Christinadobrzyn moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect May 23, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@Christinadobrzyn
Copy link
Contributor

asking tom if he can buddy check my thinking on the release timeframe - https://expensify.slack.com/archives/C036QM0SLJK/p1716884563004939

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@danielrvidal danielrvidal changed the title [$250] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM [$250] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM May 28, 2024
@Christinadobrzyn
Copy link
Contributor

still looking for someone to pick this up.

Copy link

melvin-bot bot commented May 30, 2024

@hoangzinh @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@Christinadobrzyn
Copy link
Contributor

hi @techievivek just checking on this, do you think you'll have the bandwidth to work on this or do you want me to try and find another internal volunteer?

@slafortune slafortune removed their assignment Jul 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@trjExpensify trjExpensify moved this from Polish to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 2, 2024
@trjExpensify trjExpensify changed the title [$250] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM [$250] [Guided Setup: Stage 3] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM Jul 2, 2024
@trjExpensify
Copy link
Contributor

@techievivek coming from this convo, I'm moving this into the Guided Setup: Stage 3 project to track to ensure we get to the bottom of it before the next release.

@trjExpensify trjExpensify changed the title [$250] [Guided Setup: Stage 3] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM [$250] [Guided Setup Stage 3] [CVP] Selecting Pay button from email as a new user, taking to the IOU report rather than the preview in the DM Jul 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2024
@Christinadobrzyn
Copy link
Contributor

@techievivek can you provide an update for Melvin? TY!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 3, 2024
@techievivek
Copy link
Contributor

Sent a PR to fix the behaviour of pay button.

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@techievivek techievivek added the Reviewing Has a PR in review label Jul 8, 2024
@Christinadobrzyn
Copy link
Contributor

Awesome! Should we move this to weekly @techievivek while the PR is in review?

@techievivek techievivek added Weekly KSv2 and removed Daily KSv2 labels Jul 9, 2024
@trjExpensify
Copy link
Contributor

PR has been deployed, right? I don't think there's payment here for a webPR.

@hoangzinh
Copy link
Contributor

yes @trjExpensify, no payment here.

@trjExpensify
Copy link
Contributor

Great, we're done here then. @danielrvidal is there a CVP test you want to update for this or is it accounted for?

@Christinadobrzyn
Copy link
Contributor

@danielrvidal just checking in on this question when you have a moment!

@Christinadobrzyn
Copy link
Contributor

I'll DM @danielrvidal to check on any other reason to keep this open.

@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Jul 30, 2024
@danielrvidal
Copy link
Contributor

I just tested on mobile/web and it works as expected. I'll update the CVP so it reflects this (I think it already did).

@Christinadobrzyn
Copy link
Contributor

Awesome! thank you Daniel! Closing this out.

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
No open projects
Status: Done
Development

No branches or pull requests

9 participants