[Wave Collect] [Xero] Auto-sync should be enabled by default for all integrations

[lakchote]

BUG: Auto-sync should be enabled by default for all integrations.

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[SzymczakJ]

@trjExpensify are there any specific reproduction steps? When I connect to Xero from any account the auto-sync is always toggled on

[trjExpensify]

Nothing specific, I'm afraid. I simply:

1. Created a new account (that has access to the Xero & Accounting betas)
2. Choose "Manage my team's expenses" in the onboarding modal to create a workspace
3. Enabled Accounting in More features on that workspace
4. Connected to Xero
5. Went to the Advanced page
6. Observed auto sync was disabled

I did these steps on the adhoc build of the merge freeze branch. @lakchote, if we spin up a fresh build with the latest from the Xero merge freeze branch, I'm happy to re-test this again?

[SzymczakJ]

I managed to reproduce! Looking into this.

[SzymczakJ]

After investigating for some time this is what I've found:

1. Managed to reproduce it only on a new account that has chosen "Manage my team's expenses" in the onboarding modal and therefore has a specific workspace. This bug only happens on this specific workspace.
2. When you set up a Xero connection, everything seems to work as expected but this is the onyx data(policy.connection) that comes from backend:
   
   Xero synchronisation was completed with errors, lastSync.isSuccessful = false, there is missing data in data.tenants and data.revenueAccounts fields and most importantly there is missing config.autoSync object which is reponsible for Auto-sync toggle. We haven't noticed synchronisation failure because issue for displaying sync error is still in progress.
   Just to be clear this is how proper xero connection data looks like:
   
3. I suppose this issue appears because this pre-created workspace that comes from choosing "Manage my team's expenses" has some missing/bad config and backend cannot handle it properly, but I'm not 100% sure 😅. Can someone from BE take a look at this? cc @lakchote

[lakchote]

@SzymczakJ I just tried to reproduce following your steps, and auto sync is enabled even If I choose the option Manage my team's expenses in the onboarding modal.

Also policy's connection data is correct (no sync failure):

I'm going to trigger a new build, and see if @trjExpensify can reproduce again.

[SzymczakJ]

Wasn't able to reproduce it with the same reproduction steps 😒

[lakchote]

@trjExpensify could you retest please?

The new ad hoc build has been deployed to Web.

[trjExpensify]

Nice! Retested and Auto-sync was enabled by default this time:

2024-05-21_22-09-49.mp4

[lakchote]

Great, closing this issue then. If it happens again, I'll reopen it.