Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #45289] [$250] Upgrade Expo and necessary packages #42475

Closed
bondydaa opened this issue May 22, 2024 · 23 comments
Closed

[HOLD #45289] [$250] Upgrade Expo and necessary packages #42475

bondydaa opened this issue May 22, 2024 · 23 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@bondydaa
Copy link
Contributor

bondydaa commented May 22, 2024

Coming from this PR #42357

Problem

There is a critical security fix released in Expo v51.0.8, we should update to this but need to do so in a way that doesn't break the entire app.

Solution

Create a new PR / update #42357 and test all flows using expo with the help of contributors and testers to ensure no breaking changes render the app unusable.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019dda01bf3f9b4520
  • Upwork Job ID: 1793760958218575872
  • Last Price Increase: 2024-05-23
Issue OwnerCurrent Issue Owner: @hoangzinh
@ShridharGoel
Copy link
Contributor

@bondydaa I would like to pick this (at least would like to join the testing part if contributors are needed on that).

@bgawkuc
Copy link
Contributor

bgawkuc commented May 23, 2024

@bondydaa Hi! I’m Barbara Gaweł-Kucab from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link

melvin-bot bot commented May 23, 2024

📣 @bgawkuc! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@bondydaa
Copy link
Contributor Author

@ShridharGoel thanks for the note, we'll let you know if we need more testers to jump in. For now we're going to rely on SWM to help us with the majority of the lifting for now.

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 NewFeature Something to build that is a new item. labels May 23, 2024
@melvin-bot melvin-bot bot changed the title Upgrade Expo and necessary packages [$250] Upgrade Expo and necessary packages May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019dda01bf3f9b4520

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 23, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2024
@bgawkuc
Copy link
Contributor

bgawkuc commented May 27, 2024

After research, it turned out that Expo upgrade involves bumping up RN to 0.74. The RN upgrade has started (draft PR here), so the Expo issue is blocked - @bondydaa @hoangzinh @mountiny

@mountiny
Copy link
Contributor

Alright, thanks, I will update the title to reflect that

@mountiny mountiny changed the title [$250] Upgrade Expo and necessary packages [HOLD RN 0.74 upgrage] [$250] Upgrade Expo and necessary packages May 28, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

This issue has not been updated in over 15 days. @hoangzinh, @CortneyOfstad, @bgawkuc eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jun 17, 2024
@CortneyOfstad
Copy link
Contributor

PR here is being actively worked on 👍

@CortneyOfstad
Copy link
Contributor

PR is still being worked on!

@CortneyOfstad
Copy link
Contributor

PR is still being worked on with most recent updated found here

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@CortneyOfstad
Copy link
Contributor

So the PR was closed in favor of the 0.75 update — @mountiny and @bondydaa (tagging you both since you commented on this GH). Do I keep this open for 0.75 and if so, is there something I can link to this for reference/tracking? The PR closure did not have anything and didn't want to close this without getting some additional context — thank you!

@bondydaa
Copy link
Contributor Author

hm @roryabraham can you share any context on #40548 (comment)?

@CortneyOfstad
Copy link
Contributor

@roryabraham is there a PR that I should link to this, or should this be closed in favor of another GH? Thanks!

@hoangzinh
Copy link
Contributor

RN 0.75 is merged #45289. I think we need to wait until it's deployed to Prod and then unlock this issue.

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
@roryabraham roryabraham changed the title [HOLD RN 0.74 upgrage] [$250] Upgrade Expo and necessary packages [HOLD #45289] [$250] Upgrade Expo and necessary packages Aug 26, 2024
@CortneyOfstad
Copy link
Contributor

On-hold issue is still on staging, so will continue to monitor!

@CortneyOfstad
Copy link
Contributor

@roryabraham can you confirm if RN 0.75 has been deployed into production? From what I can see in #45289 it appears to have been on staging for nearly a month, which may be normal, but wanted confirmation from a professional 😂 Thank you!

@roryabraham
Copy link
Contributor

yep! Sorry we've had issues with release comments and other automations recently, but those should be fixed now. RN 0.75 has been on prod since 2024-08-28

@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2024
@hoangzinh
Copy link
Contributor

I think we can close this issue because the Expo version has been bumped to 51.0.31 in this PR

@melvin-bot melvin-bot bot removed the Overdue label Oct 1, 2024
@roryabraham
Copy link
Contributor

agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

7 participants