Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payment card / Subscription] Implement UpdateSubscriptionAutoRenew API command #42479

Closed
amyevans opened this issue May 22, 2024 · 12 comments
Closed

[Payment card / Subscription] Implement UpdateSubscriptionAutoRenew API command #42479

amyevans opened this issue May 22, 2024 · 12 comments
Assignees
@rlinoz
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@amyevans
Copy link
Contributor

Complete this backend section of the design doc: Implement UpdateSubscriptionAutoRenew API command
@amyevans amyevans added Engineering Daily KSv2 Hot Pick Ready for an engineer to pick up and run with labels May 22, 2024
@amyevans amyevans moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 22, 2024
@amyevans amyevans moved this from Release 1.5: XeroCon 2024 (June 12th) to HOT PICKS in [#whatsnext] #wave-collect May 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 27, 2024

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 28, 2024

Huh... This is 4 days overdue. Who can take care of this?

@rlinoz rlinoz self-assigned this May 28, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@rlinoz rlinoz added Overdue and removed Hot Pick Ready for an engineer to pick up and run with labels May 28, 2024
@rlinoz
Copy link
Contributor

rlinoz commented May 28, 2024

Picking it up, hopefully opening PRs by tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@dangrous
Copy link
Contributor

Oh shoot, you got here just before I clicked the button! Let me know if you need any help (or want to split up the PRs!)

@trjExpensify trjExpensify moved this from HOT PICKS to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 28, 2024
@trjExpensify
Copy link
Contributor

@dangrous what about this one maybs? [Payment card / Subscription] Implement AddPaymentCardGBP API command?

@rlinoz rlinoz added the Reviewing Has a PR in review label May 30, 2024
@rlinoz
Copy link
Contributor

rlinoz commented May 30, 2024

PRs are up

@amyevans
Copy link
Contributor Author

amyevans commented Jun 3, 2024

Auth PR deployed to prod

@amyevans
Copy link
Contributor Author

amyevans commented Jun 3, 2024

Web PR on staging

@amyevans
Copy link
Contributor Author

amyevans commented Jun 4, 2024

Auth PR got reverted when we rolled back, and we cherry-picked a revert of the web PR to fix failing integration tests

@rlinoz
Copy link
Contributor

rlinoz commented Jun 5, 2024

Unrevert PRs are up

@rlinoz
Copy link
Contributor

rlinoz commented Jun 6, 2024

Merged all the unreverts.

@rlinoz
Copy link
Contributor

rlinoz commented Jun 10, 2024

Deployed to prod: https://github.com/Expensify/Web-Expensify/pull/42266#issuecomment-2158969374

@rlinoz rlinoz closed this as completed Jun 10, 2024
@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlinoz rlinoz

Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rlinoz @dangrous @amyevans @trjExpensify