Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread – Thread is bold in LHN when leave thread and open again, chat reloads sometimes #42515

Closed
1 of 6 tasks
lanitochka17 opened this issue May 23, 2024 · 30 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4568669
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Open any chat and send a message
  4. Create a thread and send a message
  5. Leave the thread using three dot menu
  6. Open thread again
  7. Observe the thread in LHN

Expected Result:

Thread is not bold in LHN, as it is opened. Chat doesn’t reload

Actual Result:

Thread is bold in LHN when left the chat message appears, chat reloads sometimes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489313_1716463270801.Thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018ea1c5ef6f4844fe
  • Upwork Job ID: 1798111207890632704
  • Last Price Increase: 2024-06-11
Issue OwnerCurrent Issue Owner: @hungvu193
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
Copy link

melvin-bot bot commented May 28, 2024

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented May 30, 2024

@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jun 3, 2024

@kevinksullivan 10 days overdue. Is anyone even seeing these? Hello?

@kevinksullivan
Copy link
Contributor

agree this is VSB related.

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Jun 4, 2024
@melvin-bot melvin-bot bot changed the title Thread – Thread is bold in LHN when leave thread and open again, chat reloads sometimes [$250] Thread – Thread is bold in LHN when leave thread and open again, chat reloads sometimes Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018ea1c5ef6f4844fe

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@hungvu193
Copy link
Contributor

Waiting for proposals

Copy link

melvin-bot bot commented Jun 6, 2024

@hungvu193 @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@hungvu193
Copy link
Contributor

We're still looking for proposals

Copy link

melvin-bot bot commented Jun 10, 2024

@hungvu193, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@hungvu193
Copy link
Contributor

Still looking for proposals

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@hungvu193
Copy link
Contributor

I can't reproduce this on latest main, can you please check again? @lanitochka17

Screen.Recording.2024-06-11.at.13.37.13.mov

@hungvu193
Copy link
Contributor

Also I got this error while waiting for Pusher event to update the left the chat message. I think this issue should be internal.
cc @kevinksullivan

Screenshot 2024-06-11 at 14 11 42

Copy link

melvin-bot bot commented Jun 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@hungvu193
Copy link
Contributor

This can be BE issue

@hungvu193
Copy link
Contributor

I tested this one today and can't reproduce anymore.

Can you please verify this again? @lanitochka17

Screen.Recording.2024-06-12.at.08.21.46.mov

@hungvu193
Copy link
Contributor

little bump @kevinksullivan

@hungvu193
Copy link
Contributor

Still waiting for the above question ✋

@mallenexpensify mallenexpensify self-assigned this Jun 18, 2024
@mallenexpensify mallenexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jun 18, 2024
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jun 18, 2024

@hungvu193 co-assigning since Kev's going OOO.
I get a flash but I feel like that's different than the reported bug, it appears the 'left the chat' doesn't post til the thread is revisited.

Likely close, I think. Let's see what the retest comes back with?

2024-06-17_19-18-48.mp4

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Jun 18, 2024
@hungvu193
Copy link
Contributor

I think there's another issue here that left the chat text will never show up until you refresh or re-visit that thread again.

Copy link

melvin-bot bot commented Jun 20, 2024

@hungvu193 @kevinksullivan @mallenexpensify this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@mallenexpensify
Copy link
Contributor

Checking in #expensify-open-source about
https://expensify.slack.com/archives/C01GTK53T8Q/p1718995150527849

@mallenexpensify
Copy link
Contributor

From Kevin in the chat above

Regarding "left the chat text will never show up until you refresh or re-visit that thread again." I think this is a simpler issue which might be potentially easy to solve from BE (pusher events issue).

@hungvu193 do you agree?

@hungvu193
Copy link
Contributor

From Kevin in the chat above

Regarding "left the chat text will never show up until you refresh or re-visit that thread again." I think this is a simpler issue which might be potentially easy to solve from BE (pusher events issue).

@hungvu193 do you agree?

Agreed 😄

@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Jun 24, 2024
@mallenexpensify mallenexpensify changed the title [$250] Thread – Thread is bold in LHN when leave thread and open again, chat reloads sometimes Thread – Thread is bold in LHN when leave thread and open again, chat reloads sometimes Jun 24, 2024
@mallenexpensify
Copy link
Contributor

Bumped to internal, let's see what the retest-weekly ends up returning.

@lanitochka17
Copy link
Author

Thread is bold for a moment

bandicam.2024-06-27.20-19-28-349.mp4

@mallenexpensify
Copy link
Contributor

Thanks @lanitochka17 , going to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants