[HOLD for payment 2024-08-07] [$500] Unable to add Apple's standard emojis #42588
Comments
m-natarajan
added
Daily
|
Triggered auto assignment to @kevinksullivan ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Emoji is sent as syntax in step 2 What is the root cause of that problem?We are missing 🧌 icon in the list of emojis in here What changes do you think we should make in order to solve the problem?We add all the missing icons to the list here What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.Unable to add Apple's standard emojis What is the root cause of that problem?The emoji is missing in the emoji list and translations file. Line 4 in 525ad6f Line 4 in 525ad6f What changes do you think we should make in order to solve the problem?We need to add the emoji in all three files. In common.ts: In es.ts: //
'🧌': {
keywords: ['troll', 'fairy tale', 'fantasy', 'monster'],
},In es.ts '🧌': {
name: 'trol',
keywords: ['cara', 'cuento', 'fantasía', 'monstruo', 'trol'],
},Note: We might want to adjust the keywords, What alternative solutions did you explore? (Optional) |
|
@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@kevinksullivan Eep! 4 days overdue now. Issues have feelings too... |
|
@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
|
@kevinksullivan 10 days overdue. I'm getting more depressed than Marvin. |
|
Low priority VSB bug. |
kevinksullivan
added
External
melvin-bot
bot
changed the title
|
Job added to Upwork: https://www.upwork.com/jobs/~01e356e9d1262d3053 |
melvin-bot
bot
added
the
Help Wanted
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
|
@rafecolton, I found that we are missing 80 emoji from versions 14.0, 15.0, and 15.1. We have all emojis from version 13.0 and earlier. Missing Emojisconst E140 = [
[
{
name: 'melting_face',
code: '🫠',
},
{
name: 'face_with_open_eyes_and_hand_over_mouth',
code: '🫢',
},
{
name: 'face_with_peeking_eye',
code: '🫣',
},
{
name: 'saluting_face',
code: '🫡',
},
{
name: 'dotted_line_face',
code: '🫥',
},
{
name: 'face_with_diagonal_mouth',
code: '🫤',
},
{
name: 'face_holding_back_tears',
code: '🥹',
},
{
name: 'index_pointing_at_the_viewer',
code: '🫵',
types: ['🫵🏿', '🫵🏾', '🫵🏽', '🫵🏼', '🫵🏻'],
},
{
name: 'rightwards_hand',
code: '🫱',
types: ['🫱🏿', '🫱🏾', '🫱🏽', '🫱🏼', '🫱🏻'],
},
{
name: 'leftwards_hand',
code: '🫲',
types: ['🫲🏿', '🫲🏾', '🫲🏽', '🫲🏼', '🫲🏻'],
},
{
name: 'palm_down_hand',
code: '🫳',
types: ['🫳🏿', '🫳🏾', '🫳🏽', '🫳🏼', '🫳🏻'],
},
{
name: 'palm_up_hand',
code: '🫴',
types: ['🫴🏿', '🫴🏾', '🫴🏽', '🫴🏼', '🫴🏻'],
},
{
name: 'hand_with_index_finger_and_thumb_crossed',
code: '🫰',
types: ['🫰🏿', '🫰🏾', '🫰🏽', '🫰🏼', '🫰🏻'],
},
{
name: 'heart_hands',
code: '🫶',
types: ['🫶🏿', '🫶🏾', '🫶🏽', '🫶🏼', '🫶🏻'],
},
{
name: 'person_with_crown',
code: '🫅',
types: ['🫅🏿', '🫅🏾', '🫅🏽', '🫅🏼', '🫅🏻'],
},
{
name: 'pregnant_man',
code: '🫃',
types: ['🫃🏿', '🫃🏾', '🫃🏽', '🫃🏼', '🫃🏻'],
},
{
name: 'pregnant_person',
code: '🫄',
types: ['🫄🏿', '🫄🏾', '🫄🏽', '🫄🏼', '🫄🏻'],
},
{
name: 'troll',
code: '🧌',
},
{
name: 'coral',
code: '🪸',
},
{
name: 'lotus',
code: '🪷',
},
{
name: 'empty_nest',
code: '🪹',
},
{
name: 'nest_with_eggs',
code: '🪺',
},
{
name: 'beans',
code: '🫘',
},
{
name: 'pouring_liquid',
code: '🫗',
},
{
name: 'jar',
code: '🫙',
},
{
name: 'playground_slide',
code: '🛝',
},
{
name: 'wheel',
code: '🛞',
},
{
name: 'ring_buoy',
code: '🛟',
},
{
name: 'mirror_ball',
code: '🪩',
},
{
name: 'low_battery',
code: '🪫',
},
{
name: 'crutch',
code: '🩼',
},
{
name: 'x_ray',
code: '🩻',
},
{
name: 'bubbles',
code: '🫧',
},
{
name: 'hamsa',
code: '🪬',
},
{
name: 'identification_card',
code: '🪪',
},
{
name: 'heavy_equals_sign',
code: '🟰',
},
],
];
const E150 = [
[
{
name: 'shaking_face',
code: '🫨',
},
{
name: 'pink_heart',
code: '🩷',
},
{
name: 'light_blue_heart',
code: '🩵',
},
{
name: 'grey_heart',
code: '🩶',
},
{
name: 'leftwards_pushing_hand',
code: '🫷',
types: ['🫷🏿', '🫷🏾', '🫷🏽', '🫷🏼', '🫷🏻'],
},
{
name: 'rightwards_pushing_hand',
code: '🫸',
types: ['🫸🏿', '🫸🏾', '🫸🏽', '🫸🏼', '🫸🏻'],
},
{
name: 'moose',
code: '🫎',
},
{
name: 'donkey',
code: '🫏',
},
{
name: 'wing',
code: '🪽',
},
{
name: 'black_bird',
code: '🐦⬛',
},
{
name: 'goose',
code: '🪿',
},
{
name: 'jellyfish',
code: '🪼',
},
{
name: 'hyacinth',
code: '🪻',
},
{
name: 'ginger',
code: '🫚',
},
{
name: 'pea_pod',
code: '🫛',
},
{
name: 'folding_hand_fan',
code: '🪭',
},
{
name: 'hair_pick',
code: '🪮',
},
{
name: 'maracas',
code: '🪇',
},
{
name: 'flute',
code: '🪈',
},
{
name: 'khanda',
code: '🪯',
},
{
name: 'wireless',
code: '🛜',
},
],
];
const V151 = [
[
{
name: 'head_shaking_horizontally',
code: '🙂↔️',
},
{
name: 'head_shaking_vertically',
code: '🙂↕️',
},
{
name: 'person_walking_facing_right',
code: '🚶➡️',
types: ['🚶🏿➡️', '🚶🏾➡️', '🚶🏽➡️', '🚶🏼➡️', '🚶🏻➡️'],
},
{
name: 'woman_walking_facing_right',
code: '🚶♀️➡️',
types: ['🚶🏿♀️➡️', '🚶🏾♀️➡️', '🚶🏽♀️➡️', '🚶🏼♀️➡️', '🚶🏻♀️➡️'],
},
{
name: 'man_walking_facing_right',
code: '🚶♂️➡️',
types: ['🚶🏿♂️➡️', '🚶🏾♂️➡️', '🚶🏽♂️➡️', '🚶🏼♂️➡️', '🚶🏻♂️➡️'],
},
{
name: 'person_kneeling_facing_right',
code: '🧎➡️',
types: ['🧎🏿➡️', '🧎🏾➡️', '🧎🏽➡️', '🧎🏼➡️', '🧎🏻➡️'],
},
{
name: 'woman_kneeling_facing_right',
code: '🧎♀️➡️',
types: ['🧎🏿♀️➡️', '🧎🏾♀️➡️', '🧎🏽♀️➡️', '🧎🏼♀️➡️', '🧎🏻♀️➡️'],
},
{
name: 'man_kneeling_facing_right',
code: '🧎♂️➡️',
types: ['🧎🏿♂️➡️', '🧎🏾♂️➡️', '🧎🏽♂️➡️', '🧎🏼♂️➡️', '🧎🏻♂️➡️'],
},
{
name: 'person_with_white_cane_facing_right',
code: '🧑🦯➡️',
types: ['🧑🏿🦯➡️', '🧑🏾🦯➡️', '🧑🏽🦯➡️', '🧑🏼🦯➡️', '🧑🏻🦯➡️'],
},
{
name: 'man_with_white_cane_facing_right',
code: '👨🦯➡️',
types: ['👨🏿🦯➡️', '👨🏾🦯➡️', '👨🏽🦯➡️', '👨🏼🦯➡️', '👨🏻🦯➡️'],
},
{
name: 'woman_with_white_cane_facing_right',
code: '👩🦯➡️',
types: ['👩🏿🦯➡️', '👩🏾🦯➡️', '👩🏽🦯➡️', '👩🏼🦯➡️', '👩🏻🦯➡️'],
},
{
name: 'person_in_motorized_wheelchair_facing_right',
code: '🧑🦼➡️',
types: ['🧑🏿🦼➡️', '🧑🏾🦼➡️', '🧑🏽🦼➡️', '🧑🏼🦼➡️', '🧑🏻🦼➡️'],
},
{
name: 'man_in_motorized_wheelchair_facing_right',
code: '👨🦼➡️',
types: ['👨🏿🦼➡️', '👨🏾🦼➡️', '👨🏽🦼➡️', '👨🏼🦼➡️', '👨🏻🦼➡️'],
},
{
name: 'woman_in_motorized_wheelchair_facing_right',
code: '👩🦼➡️',
types: ['👩🏿🦼➡️', '👩🏾🦼➡️', '👩🏽🦼➡️', '👩🏼🦼➡️', '👩🏻🦼➡️'],
},
{
name: 'person_in_manual_wheelchair_facing_right',
code: '🧑🦽➡️',
types: ['🧑🏿🦽➡️', '🧑🏾🦽➡️', '🧑🏽🦽➡️', '🧑🏼🦽➡️', '🧑🏻🦽➡️'],
},
{
name: 'man_in_manual_wheelchair_facing_right',
code: '👨🦽➡️',
types: ['👨🏿🦽➡️', '👨🏾🦽➡️', '👨🏽🦽➡️', '👨🏼🦽➡️', '👨🏻🦽➡️'],
},
{
name: 'woman_in_manual_wheelchair_facing_right',
code: '👩🦽➡️',
types: ['👩🏿🦽➡️', '👩🏾🦽➡️', '👩🏽🦽➡️', '👩🏼🦽➡️', '👩🏻🦽➡️'],
},
{
name: 'person_running_facing_right',
code: '🏃➡️',
types: ['🏃🏿➡️', '🏃🏾➡️', '🏃🏽➡️', '🏃🏼➡️', '🏃🏻➡️'],
},
{
name: 'woman_running_facing_right',
code: '🏃♀️➡️',
types: ['🏃🏿♀️➡️', '🏃🏾♀️➡️', '🏃🏽♀️➡️', '🏃🏼♀️➡️', '🏃🏻♀️➡️'],
},
{
name: 'man_running_facing_right',
code: '🏃♂️➡️',
types: ['🏃🏿♂️➡️', '🏃🏾♂️➡️', '🏃🏽♂️➡️', '🏃🏼♂️➡️', '🏃🏻♂️➡️'],
},
{
name: 'family_adult_adult_child',
code: '🧑🧑🧒',
},
{
name: 'family_adult_adult_child_child',
code: '🧑🧑🧒🧒',
},
{
name: 'family_adult_child',
code: '🧑🧒',
},
{
name: 'family_adult_child_child',
code: '🧑🧒🧒',
},
{
name: 'phoenix',
code: '🐦🔥',
},
{
name: 'lime',
code: '🍋🟩',
},
{
name: 'brown_mushroom',
code: '🍄🟫',
},
{
name: 'broken_chain',
code: '⛓️💥',
},
],
]; |
|
@kevinksullivan @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
|
Not overdue, looking for proposals. |
|
Taking this over (thread). |
|
I think @Krishna2323 proposal makes sense. We should focus on adding all the missing emojis as a part of the scope. In the long term we should improve on keeping these in sync. But I feel in the current issue we should only look at adding them manually. 🎀 👀 🎀 C+ reviewed. |
|
Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
@Krishna2323 @mananjadhav is it possible that we caused this blocker? |
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
melvin-bot
bot
added
Weekly
melvin-bot
bot
changed the title
|
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-07. 🎊 For reference, here are some details about the assignees on this issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
@mananjadhav can you complete the steps above? |
|
Payment summary:
|
|
@Krishna2323 job expired so I created a new one. Lmk when you accept! https://www.upwork.com/ab/applicants/1822048410581815910/job-details |
|
@deetergp, @rafecolton, @mananjadhav, @kevinksullivan, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@kevinksullivan, offer accepted. Thanks |
|
Raised request on NewDot. |
|
$500 approved for @mananjadhav |
|
@deetergp, @rafecolton, @mananjadhav, @kevinksullivan, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too... |
|
@kevinksullivan, I have accepted the offer, can you please complete the payment when you have some time? Thanks |
|
@deetergp, @rafecolton, @mananjadhav, @kevinksullivan, @Krishna2323 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
|
all set! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716485230886559
Action Performed:
Expected Result:
Describe what you think should've happened
Emoji is sent in the step 2
When hovering the emoji should show the added emoji in step 4
Actual Result:
Emoji is sent as syntax in step 2
Only
::shows in step 4Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.3126.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @kevinksullivanThe text was updated successfully, but these errors were encountered: