[$250] [HOLD for payment 2024-08-01] Group name - RBR doesn't disappear from LHN after removing error message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41826

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a group chat
3. Go offline
4. Rename the group to something invalid for example "adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ"
5. Go online
6. Follow the RBR and remove the error message

Expected Result:

RBR on LHN gets removed from LHN as well

Actual Result:

RBR stays on LHN even after removing error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495078_1716985565573.bandicam_2024-05-29_15-20-11-422.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f34a445311dae423
• Upwork Job ID: 1821299949503498320
• Last Price Increase: 2024-08-07

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR doesn't disappear from LHN after removing error message

What is the root cause of that problem?

Here we call clearPolicyRoomNameErrors

App/src/pages/settings/Report/ReportSettingsPage.tsx

Line 76 in 53f9e57

onClose={() => ReportActions.clearPolicyRoomNameErrors(reportID)}

and in clearPolicyRoomNameErrors we only clear errorFields but not errors

App/src/libs/actions/Report.ts

Lines 2220 to 2229 in c244fa1

	function clearPolicyRoomNameErrors(reportID: string) {
	Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {
	errorFields: {
	reportName: null,
	},
	pendingFields: {
	reportName: null,
	},
	});
	}

and here when we fail we set errors to common.genericErrorMessage

App/src/libs/actions/Report.ts

Lines 665 to 667 in 169a3aa

	errors: {
	reportName: Localize.translateLocal('common.genericErrorMessage'),
	},

So the RCA is when "x" is pressed we clear errorFields but not errors

What changes do you think we should make in order to solve the problem?

Solution 1
Instead of setting errors here set "errorFields" error to invalid Name

App/src/libs/actions/Report.ts

Lines 665 to 667 in 169a3aa

	errors: {
	reportName: Localize.translateLocal('common.genericErrorMessage'),
	},

Note:we can keep errors here too.

What alternative solutions did you explore? (Optional)

In clearPolicyRoomNameErrors also clear errors or create a new function to use here

App/src/libs/actions/Report.ts

Lines 2220 to 2229 in c244fa1

	function clearPolicyRoomNameErrors(reportID: string) {
	Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {
	errorFields: {
	reportName: null,
	},
	pendingFields: {
	reportName: null,
	},
	});
	}

        errors: {
                    reportName: 'null',
                },

[puneetlath]

Doesn't seem blocker-worthy to me. Let's treat as a regular bug.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[muttmuure]

Catching up from OOO

[muttmuure]

Not overdue

[Nodebrute]

@rojiphil bump

[rojiphil]

@muttmuure Completed BZ checklist.
I am not finding the upwork offer for this. Can you please create an offer if not present somewhere? Thanks.

[melvin-bot]

@rojiphil, @danieldoglas, @mountiny, @muttmuure, @Nodebrute Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[danieldoglas]

@mallenexpensify can you please take care of the payment on this one? Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f34a445311dae423

[melvin-bot]

Current assignee @rojiphil is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@rojiphil @Nodebrute , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f34a445311dae423

[Nodebrute]

@mallenexpensify I haven’t received the Upwork offer yet. Can you send the contract manually when you get a chance?

[mallenexpensify]

Musta forgot to invite ¯_(ツ)_/¯, plz accept meow 🐱
https://www.upwork.com/jobs/~01f34a445311dae423

[Nodebrute]

@mallenexpensify thank you, accepted.

[rojiphil]

@mallenexpensify Accepted offer. Thanks.

[danieldoglas]

payment in progress

[mallenexpensify]

Contributor: @Nodebrute paid $250 via Upwork
Contributor+: @rojiphil paid $250 via NewDot

@rojiphil do we want a regression test for this? If not, why not? Thx

[rojiphil]

Contributor: @Nodebrute paid $250 via Upwork Contributor+: @rojiphil paid $250 via NewDot

@rojiphil do we want a regression test for this? If not, why not? Thx

@mallenexpensify As mentioned in BZ checklist here, I think we can skip the regression test as this is an edge case.

[mallenexpensify]

BZ checklist #42765 (comment),

@rojiphil , it looks like you just checked the box there. We also want reasoning if we don't create a test case. We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.

I created a test case using the steps in the PR

• https://github.com/Expensify/Expensify/issues/420197

[rojiphil]

We want to err on the side of creating more test cases because the QA will know if it's needed. They also have a separate monthly test for edge cases.

@mallenexpensify Ok. Got it and noted too. Thanks.