[Hold for Payment 2024-09-03][$250] [Pending/Scanning] The count of expenses on a report is not calculating correctly for card transactions

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-4
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026569202759

Details on simulating card transactions below

Action Performed:

1. Set up workspace and enable workflows
2. Navigate to workflows and enable approvals
3. Assign expensify card to a member on that workspace
4. Incur a card transaction
5. Incur another card transaction

Expected Result:

The expense count should show as total# expenses (x scanning, y pending)

Actual Result:

The expense count is 0

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179ad48857375d973
• Upwork Job ID: 1810354497668334430
• Last Price Increase: 2024-08-19

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[kevinksullivan]

added another datapoint here

https://expensify.slack.com/archives/C049HHMV9SM/p1717089079785199?thread_ts=1717026569.202759&cid=C049HHMV9SM

[mallenexpensify]

Internal since you need a card to test. @trjExpensify , I added to  #wave-collect and set status as Release 2 (since the roadmap doc said 'card support' was then)

[trjExpensify]

Yep! CC: @kevinksullivan @grgia

[mallenexpensify]

Waiting to get picked up internally

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

@trjExpensify what's the (project) priority for this? Considering how hard I want to push to find an internal volunteer. Thx

[trjExpensify]

Pending/Scanning is high for the summer release. This pending/scanning project is still in dev, so I'm not sure if @grgia's recent work will catch this or it needs to be looked into separately. If it's a frontend issue, I wonder if there's instructions for a contributor to simulate pending card transactions on dev to test we could provide.

[grgia]

Is this still reproducible? This most likely is a FE issue

[grgia]

Assigning to keep track of this for now

[mallenexpensify]

Posted in #expensify-open-source

Does anyone know if we have instructions for a contributor to simulate pending card transactions on dev? I couldn't find anything in SO or searching this room (it's for this GH) (edited)

Also threw retest-weekly since QA might be able to confirm reproduction more easily.

[getusha]

@mallenexpensify this was created after 2024-05-25 (my eligibility date) so we can use this to knock the remaining $250 i owe #32699 (comment)

[mallenexpensify]

@getusha , for this issue, I'm seeing

• assigned getusha on Jul 3 - here

And, yes, I see your eligibility date of 2024-05-25

[melvin-bot]

@mallenexpensify, @grgia, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@getusha can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b3d83125b1d4f841

Also, can you please confirm you have not been paid for this issue via NewDot and that you cancelled any requests you have for payment via NewDot? Thx

[getusha]

@mallenexpensify accepted

Also, can you please confirm you have not been paid for this issue via NewDot and that you cancelled any requests you have for payment via NewDot? Thx

Yes i haven't been paid via ND

[mallenexpensify]

Contributor+: @getusha paid $250 via Upwork

Lastly.. can you fill out the checklist below? I imagine we want a regression test for this, right?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@] The PR that introduced the bug has been identified. Link to the PR:
• [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@] Determine if we should create a regression test for this bug.
• [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
• [ ]

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR: Fix x requests, y scanning count in ReportPreview  #34191
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Looks like it was by design at that moment.
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
• Determine if we should create a regression test for this bug. I don't think there is an easy way to test this for QA

[mallenexpensify]

@getusha can you propose regression test steps plz? I agree with you that QA might not be able to test but, if not, I wan to know why so I can possibly update their process/access to allow for testing. Thx

[getusha]

@mallenexpensify QA wasn't able to make transaction using expensify card check this #47745 (comment)

[mallenexpensify]

Thanks @getusha I'm going to leave this open for a bit and mark me as the owner. Working on an internal issue for getting C+ (and possibly QA) access to cards for testing

• https://github.com/Expensify/Expensify/issues/423994#issue-2492567759

[melvin-bot]

This issue has not been updated in over 15 days. @mallenexpensify, @grgia, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[grgia]

@mallenexpensify can we close this one

[mallenexpensify]

Yup!!!! 📕