Reset amount on reset button click #42897

kaushiktd · 2024-05-31T07:16:03Z

Details

Fixed Issues

$ #41763
PROPOSAL: #41763 (comment)

Tests

Launch New Expensify app.
Go to FAB > Split expense.
Enter amount and select a few users.
Tap on split amount input.
Manually enter the split amount.
With keyboard up, tap on Reset button.
Verify the split amount is reset

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch New Expensify app.
Go to FAB > Split expense.
Enter amount and select a few users.
Tap on split amount input.
Manually enter the split amount.
With keyboard up, tap on Reset button.
Verify the split amount is reset

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

androidweb.webm

iOS: Native

ios.webm

iOS: mWeb Safari

iosweb.webm

MacOS: Chrome / Safari

web.webm

MacOS: Desktop

Desktop.webm

melvin-bot · 2024-05-31T07:16:07Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kaushiktd · 2024-05-31T08:50:53Z

@eVoloshchak PR ready

eVoloshchak · 2024-06-03T17:11:10Z

src/components/MoneyRequestAmountInput.tsx

@@ -82,6 +82,9 @@ type MoneyRequestAmountInputProps = {
     * Autogrow input container length based on the entered text.
     */
    autoGrow?: boolean;
+
+    /** Flag indicating if the reset button was clicked to reset the amount */
+    resetClicked?: boolean;


I think we should improve the naming to be more self-explanatory
Perhaps shouldResetAmount would work?

eVoloshchak · 2024-06-03T17:12:17Z

src/components/MoneyRequestAmountInput.tsx

@@ -135,6 +139,7 @@ function MoneyRequestAmountInput(
    });

    const forwardDeletePressedRef = useRef(false);
+    const resetFlag = useRef(false);


Let's call this the same as the new prop (resetClicked/shouldResetAmount/or whichever it ends up being called)

eVoloshchak · 2024-06-03T17:15:39Z

@kaushiktd, also please

include screen recordings for all of the platforms. Even if the changes apply to one of the platforms, it's still a good way to double-check there are no regressions on other platforms
append the following step to Tests: Verify the split amount is reset and the keyboard stays open

kaushiktd · 2024-06-06T15:39:11Z

@eVoloshchak PR ready. Please check.

eVoloshchak · 2024-06-11T12:37:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-07-02-12-26-37.mp4

Android: mWeb Chrome

Screen.Recording.2024-07-02.at.12.08.29.mov

iOS: Native

Screen.Recording.2024-07-01.at.19.56.50.mov

iOS: mWeb Safari

Screen.Recording.2024-07-01.at.22.27.35.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-01.at.19.51.48.mov

MacOS: Desktop

Screen.Recording.2024-07-02.at.12.11.18.mov

eVoloshchak

@kaushiktd, the behavior on native platforms and mWeb is different: on mWeb the keyboard is dismissed after you press 'reset', while on native it stays open.
According to #41763 (comment), the desired behavior is for the keyboard to stay open

iOS.native.mov

mWeb.Safari.mov

kaushiktd · 2024-06-12T03:50:17Z

@eVoloshchak
The issue was specifically about Android and iOS devices, which I have successfully resolved. If you would like to address the mWeb behavior as well, I believe this should be addressed as a separate issue. Working on mWeb will require the same amount of time as the original issue. Since only Android and iOS are checked, I considered that. So I think this issue here is fixed for the platforms as stated originally. Also, that comment you highlighted was a requested possibility, but is not mentioned in the original issue to check that platform. So I believe this PR should be approved for merging and I can work on mWeb as separate issue if you want to raise new issue for that.

kaushiktd · 2024-06-14T03:08:15Z

Friendly bump @eVoloshchak

kaushiktd · 2024-06-24T04:05:37Z

@eVoloshchak any update?

eVoloshchak · 2024-06-24T10:31:21Z

Apologies for the delay @kaushiktd

Also, that comment you highlighted was a requested possibility, but is not mentioned in the original issue to check that platform.

I do agree with this, the issue description specifically mentions native platforms. Let's fix it here and then decide if the same is worth doing for mWeb
@kaushiktd, could you merge the latest main please?

kaushiktd · 2024-06-24T11:50:01Z

@eVoloshchak if I'm understanding it correctly, you are asking me to do the PR again, right? Not requesting mWeb.

kaushiktd · 2024-07-01T15:16:40Z

Friendly bump @eVoloshchak

eVoloshchak

LGTM!

@kaushiktd, could you please add the following last step to Test steps:
Verify the split amount is reset

youssef-lr · 2024-07-02T21:27:09Z

Making a build to test this out

github-actions · 2024-07-02T22:03:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42897/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42897/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42897/NewExpensify.dmg	https://42897.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

kaushiktd · 2024-07-09T08:06:32Z

@eVoloshchak @youssef-lr friendly bump on this for an update

youssef-lr

LGTM

youssef-lr · 2024-07-09T22:24:40Z

Can we fix conflicts please?

shawnborton · 2024-07-10T06:37:46Z

I think this looks good from a design standpoint too.

shawnborton · 2024-07-10T06:39:08Z

From the recordings though, it looks like on iOS, hitting reset keeps you focused in the same input you were editing. But on desktop, hitting Reset makes you lose focus on the input you were editing. Is that on purpose?

kaushiktd · 2024-07-10T08:56:50Z

@shawnborton this is the default behaviour of desktop as well as web

shawnborton · 2024-07-10T08:59:15Z

Sounds good, thanks for confirming!

…

On Wed, Jul 10, 2024 at 10:57 AM Kaushik Kapadiya ***@***.***> wrote: @shawnborton <https://github.com/shawnborton> this is the default behaviour of desktop as well as web — Reply to this email directly, view it on GitHub <#42897 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARWH5SP24YIX5VBNC2XA6DZLTZOTAVCNFSM6AAAAABISILTJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZHE2DIMJUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

youssef-lr

LGTM

OSBotify · 2024-07-11T15:36:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

war-in · 2024-07-12T09:31:46Z

src/components/MoneyRequestAmountInput.tsx

-
-        // we want to re-initialize the state only when the amount changes
-        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-    }, [amount, shouldKeepUserInput]);
+    }, [amount, currency, formatAmountOnBlur, shouldKeepUserInput, onFormatAmount, shouldResetAmount, onResetAmount, currentAmount]);


Hey 👋 It looks like this change introduced a bug (check the revert PR description)

cc @mountiny

I tried to bring those lines back

// we want to re-initialize the state only when the amount changes // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps }, [amount, shouldKeepUserInput]);

and the input is working again, so a fix should be pretty easy :)

Heads up we ended up reverting this PR because of the above mentioned critical issue.

We opted for a revert to make sure there are no other unwanted regressions

@kaushiktd can you raise a new PR and make sure to test for the input working well

OSBotify · 2024-07-15T21:03:44Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:12:28Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:17:40Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:48:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Reset amount on reset button click

78f25f7

kaushiktd requested a review from a team as a code owner May 31, 2024 07:16

melvin-bot bot removed the request for review from a team May 31, 2024 07:16

melvin-bot bot requested a review from eVoloshchak May 31, 2024 07:16

kaushiktd added 7 commits May 31, 2024 12:58

Reset amount on reset button click

5a4feba

Reset amount on reset button click

98c2c78

Reset amount on reset button click

37af19b

Reset amount on reset button click

4b30dd9

Reset amount on reset button click

4c4e872

Reset amount on reset button click

cde4e5f

Reset amount on reset button click

c805f32

eVoloshchak suggested changes Jun 3, 2024

View reviewed changes

kaushiktd added 7 commits June 6, 2024 19:23

Resolve Conflict

812ce37

Reset amount on reset button click

7cd56e9

Reset amount on reset button click

8f71b5d

Reset amount on reset button click

057afeb

Reset amount on reset button click

bc0b3b3

Reset amount on reset button click

96c4aca

Reset amount on reset button click

1f5660c

eVoloshchak reviewed Jun 11, 2024

View reviewed changes

eVoloshchak approved these changes Jul 2, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr July 2, 2024 10:34

youssef-lr added the Ready To Build label Jul 2, 2024

youssef-lr previously approved these changes Jul 9, 2024

View reviewed changes

Reset amount on reset button click

5a2602c

kaushiktd dismissed youssef-lr’s stale review via 5a2602c July 10, 2024 06:02

kaushiktd requested a review from a team as a code owner July 10, 2024 06:03

kaushiktd added 3 commits July 10, 2024 13:40

Reset amount on reset button click

221b7a9

Reset amount on reset button click

bf86b78

Reset amount on reset button click

b1eda3e

youssef-lr approved these changes Jul 11, 2024

View reviewed changes

youssef-lr merged commit 109d4aa into Expensify:main Jul 11, 2024
14 checks passed

war-in mentioned this pull request Jul 12, 2024

Revert "Reset amount on reset button click" #45328

Merged

48 tasks

war-in reviewed Jul 12, 2024

View reviewed changes

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

melvin-bot bot mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up #41763

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reset amount on reset button click #42897

Reset amount on reset button click #42897

kaushiktd commented May 31, 2024 •

edited

Loading

melvin-bot bot commented May 31, 2024

kaushiktd commented May 31, 2024

eVoloshchak Jun 3, 2024

eVoloshchak Jun 3, 2024

eVoloshchak commented Jun 3, 2024

kaushiktd commented Jun 6, 2024

eVoloshchak commented Jun 11, 2024 •

edited

Loading

eVoloshchak left a comment

kaushiktd commented Jun 12, 2024

kaushiktd commented Jun 14, 2024

kaushiktd commented Jun 24, 2024

eVoloshchak commented Jun 24, 2024

kaushiktd commented Jun 24, 2024

kaushiktd commented Jul 1, 2024

eVoloshchak left a comment

youssef-lr commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

kaushiktd commented Jul 9, 2024

youssef-lr left a comment

youssef-lr commented Jul 9, 2024

shawnborton commented Jul 10, 2024

shawnborton commented Jul 10, 2024

kaushiktd commented Jul 10, 2024

shawnborton commented Jul 10, 2024 via email

youssef-lr left a comment

OSBotify commented Jul 11, 2024

war-in Jul 12, 2024

war-in Jul 12, 2024

mountiny Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

Reset amount on reset button click #42897

Reset amount on reset button click #42897

Conversation

kaushiktd commented May 31, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 31, 2024

kaushiktd commented May 31, 2024

eVoloshchak Jun 3, 2024

Choose a reason for hiding this comment

eVoloshchak Jun 3, 2024

Choose a reason for hiding this comment

eVoloshchak commented Jun 3, 2024

kaushiktd commented Jun 6, 2024

eVoloshchak commented Jun 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

kaushiktd commented Jun 12, 2024

kaushiktd commented Jun 14, 2024

kaushiktd commented Jun 24, 2024

eVoloshchak commented Jun 24, 2024

kaushiktd commented Jun 24, 2024

kaushiktd commented Jul 1, 2024

eVoloshchak left a comment

Choose a reason for hiding this comment

youssef-lr commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

kaushiktd commented Jul 9, 2024

youssef-lr left a comment

Choose a reason for hiding this comment

youssef-lr commented Jul 9, 2024

shawnborton commented Jul 10, 2024

shawnborton commented Jul 10, 2024

kaushiktd commented Jul 10, 2024

shawnborton commented Jul 10, 2024 via email

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 11, 2024

war-in Jul 12, 2024

Choose a reason for hiding this comment

war-in Jul 12, 2024

Choose a reason for hiding this comment

mountiny Jul 12, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

kaushiktd commented May 31, 2024 •

edited

Loading

eVoloshchak commented Jun 11, 2024 •

edited

Loading