Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Live Markdown] Styling for empty nested block quotes #43199

Closed
thienlnam opened this issue Jun 6, 2024 · 11 comments
Closed

[Live Markdown] Styling for empty nested block quotes #43199

thienlnam opened this issue Jun 6, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@thienlnam
Copy link
Contributor

Corresponds with #41107

Inserting a nested empty block quote breaks the styling

The paddings for the nested blockquotes are causing height differences between the containers, and the min-height of the container isn't set, so when we try to insert empty blockquotes, we end up with the situation presented below.

image

cc @BrtqKr

@thienlnam thienlnam added Monthly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jun 6, 2024
@thienlnam
Copy link
Contributor Author

@BrtqKr Is this something you'd like to handle or shall we make it external?

@thienlnam thienlnam added Monthly KSv2 and removed Daily KSv2 labels Jun 6, 2024
@BrtqKr
Copy link
Contributor

BrtqKr commented Jun 6, 2024

@thienlnam I can take over this, thanks for letting me know!

@BrtqKr
Copy link
Contributor

BrtqKr commented Jun 10, 2024

Update for today:
I've got most of the changes, but the empty lines are a bit tricky to handle, so I'm trying to fix it at the moment.

@BrtqKr
Copy link
Contributor

BrtqKr commented Jun 11, 2024

Update for today:
Draft is ready for the review from someone from SWM and we'll be passing it further soon. Also, there are some styling changes in the core app, but since getting rid of the margins completely is probably out of question I'm looking for a workaround

@thienlnam thienlnam moved this to LOW in Live Markdown Jun 19, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

@anmurali @BrtqKr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@anmurali
Copy link

Asked for an update on Slack - https://expensify.slack.com/archives/C04878MDF34/p1721174878190149

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2024
@BrtqKr
Copy link
Contributor

BrtqKr commented Jul 26, 2024

@thienlnam
Moving the discussion from slack, I've commented on the other ticket related to that as well.

To sum up - there have been a lot of issues related to the behavior of blockquotes, describing different, sometimes conflicting results as desired. We've been discussing it internally and we think we should take a different approach in this case. Can we please:

Pass this document further inside the Expensify team.
Make the decisions regarding cases described in the document.
Create a single ticket to adjust those behaviors on both sides - the input and the parser. And redirect all blockquotes-related reports to that place
We think that we're lacking a single source of truth with an appropriate description for the parser and the general approach to fixing those things seems a bit chaotic and blindly adjusting regexes without a broad context might not be the best workflow.

@thienlnam
Copy link
Contributor Author

Thanks, I agree it can get confusing with the different issues with conflicting expected results.

One thing we'll also want to have done is just make sure the regression tests for Live Markdown are cleaned up so they're always testing and know what correct behaviors are.

I'll take a look through this week and create a single issue to address all of those things

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@anmurali
Copy link

@thienlnam what are we gonna do here?

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2024
@thienlnam
Copy link
Contributor Author

Forgot to follow back here, but looked through the document and a lot of them are edge cases with blockquotes and unless there's an issue we're trying to solve specifically it doesn't seem like we need to keep going with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants