Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cash · Duplicate · Hold doesn't appeared for duplicates expenses #43428

Closed
2 of 6 tasks
lanitochka17 opened this issue Jun 10, 2024 · 12 comments
Closed
2 of 6 tasks

Cash · Duplicate · Hold doesn't appeared for duplicates expenses #43428

lanitochka17 opened this issue Jun 10, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.81-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #40153

Action Performed:

Precondition:

  • The Collect workspace has Expenses >> Expense Violations enabled
  1. Log in with Collect workspace's member account
  2. Create 2 expenses with same AMOUNT, CURRENCY, MERCHANT and DATE to the Collect workspace
  3. Go to the transaction report
  4. Go to the policy expense report

Expected Result:

Verify in the policy expense report, the report preview has a red dot indicator
Verify each expense preview has a red dot indicator and Cash · Duplicate · Hold on top
Verify the HOLD banner is added with the following copy This expense has the same details as another one. Review the duplicates to remove the hold

Actual Result:

Hold doesn't appeared for duplicates expenses

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6508525_1718046376802.az_recorder_20240610_135842.mp4
Bug6508525_1718046376810.web.mp4
05 27

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@gijoe0295
Copy link
Contributor

@pecanoro I guess tester needs to be added to violation beta.

@greg-schroeder
Copy link
Contributor

Okay is this the result of an actual bug or missing beta functionality?

@gijoe0295
Copy link
Contributor

gijoe0295 commented Jun 11, 2024

@greg-schroeder I'm not sure. These seems to fail all the test cases in the related PR. My best guess is that they were not added to violation beta but not sure how to verify with them.

@pecanoro
Copy link
Contributor

@lanitochka17 Do you know if the tester was added to the beta? If not, I suggest testing with a applause.expensifail.com email since that domain should have all betas enabled

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@akinwale
Copy link
Contributor

akinwale commented Jun 16, 2024

@pecanoro Additionally, a reminder that while we were testing, we had to use a Control workspace since the Expense Violations switch for Collect workspaces wasn't working as expected.

@greg-schroeder
Copy link
Contributor

Bump @lanitochka17 on #43428 (comment)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 17, 2024
@greg-schroeder
Copy link
Contributor

Bump @lanitochka17 <3

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@pecanoro
Copy link
Contributor

This is under a new beta so I don't think anyone can see it unless they gets added

@lanitochka17
Copy link
Author

Issue isn't reproducible with expensifail account

repro.no.mp4

@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@greg-schroeder
Copy link
Contributor

Closing for now as I think it was a not-being-on-the-beta issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants