Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chats - User remains on LHN page after onboarding flow completed #43564

Closed
4 of 6 tasks
izarutskaya opened this issue Jun 12, 2024 · 10 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Jun 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #41343
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Issue found when executing PR #41343

Action Performed:

Precondition: user should be Signed Out

  1. Open app
  2. Write any email with public domain which was not user for registration before
  3. Click on Continue button
  4. Click on Join button
  5. Select any onboarding option
  6. Complete the onboarding flow

Expected Result:

User should be redirected either to the Concierge chat or Expensify persona

Actual Result:

User remains on LHN page after onboarding flow completed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6510287_1718171301900.RPReplay_Final1718165520.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170226485ccb489be
  • Upwork Job ID: 1802805545916133888
  • Last Price Increase: 2024-06-17
Issue OwnerCurrent Issue Owner: @hoangzinh
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@cretadn22
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

User remains on LHN page after onboarding flow completed

What is the root cause of that problem?

// Only navigate to concierge chat when central pane is visible
// Otherwise stay on the chats screen.
if (isSmallScreenWidth) {
Navigation.navigate(ROUTES.HOME);
} else if (AccountUtils.isAccountIDOddNumber(accountID ?? 0)) {

Currently, the App only navigate to concierge chat when central pane is visible

What changes do you think we should make in order to solve the problem?

Let's delete this part

// Otherwise stay on the chats screen.
if (isSmallScreenWidth) {

The app will then redirect users to the concierge chat when onboarding flow completed

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Copy link

melvin-bot bot commented Jun 17, 2024

@slafortune Huh... This is 4 days overdue. Who can take care of this?

@slafortune slafortune added the External Added to denote the issue can be worked on by a contributor label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0170226485ccb489be

@melvin-bot melvin-bot bot changed the title Chats - User remains on LHN page after onboarding flow completed [$250] Chats - User remains on LHN page after onboarding flow completed Jun 17, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@hoangzinh
Copy link
Contributor

Confirming expected behavior here #41343 (comment)

@mountiny
Copy link
Contributor

It seems like you should be redirected to the chat #38774 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jun 20, 2024
@mountiny
Copy link
Contributor

asked https://expensify.slack.com/archives/C036QM0SLJK/p1718885687316199

@mountiny
Copy link
Contributor

This seems to be by design on narrow devices https://expensify.slack.com/archives/C036QM0SLJK/p1718898938705079?thread_ts=1718885687.316199&cid=C036QM0SLJK

@slafortune would you be able to please update any testrail cases related to this to make sure they say that on mobile/ narrow screens the users are navigated to LHN after completing the flow? thank you!

@mountiny mountiny self-assigned this Jun 20, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@slafortune
Copy link
Contributor

Added to the regression test - close since this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants