Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] [UX Reliability] Expensify DM showing in focus mode in LHN despite not having any new messages #43784

Closed
puneetlath opened this issue Jun 14, 2024 · 5 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Jun 14, 2024

Problem

In focus mode, only pinned chats, drafts, GBR, unread chats should be showing in LHN. There is now also an Expensify onboarding chat that is not unread, has not new messages, no GBR or RBR in it. Here is the onyx data.

{
    "reportID": "2440351539034289",
    "reportName": "Chat Report",
    "type": "chat",
    "chatType": "system",
    "ownerAccountID": 0,
    "managerID": 0,
    "policyID": "_FAKE_",
    "participants": {
        "778531": {
            "hidden": false
        },
        "11665625": {
            "hidden": false
        }
    },
    "isPinned": false,
    "lastReadTime": "2024-04-26 14:56:02.997",
    "lastReadSequenceNumber": 0,
    "lastVisibleActionCreated": "2024-04-26 14:56:02.997",
    "lastVisibleActionLastModified": "2024-04-26 14:56:02.997",
    "lastMessageText": "",
    "lastActionType": "CREATED",
    "lastActorAccountID": "",
    "notificationPreference": "daily",
    "stateNum": 0,
    "statusNum": 0,
    "oldPolicyName": "",
    "isOwnPolicyExpenseChat": false,
    "lastMessageHtml": "",
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "policyName": "",
    "writeCapability": "all",
    "description": "",
    "total": 0,
    "unheldTotal": 0,
    "currency": "USD",
    "isWaitingOnBankAccount": false,
    "nonReimbursableTotal": 0,
    "isCancelledIOU": false,
    "permissions": [
        "read"
    ],
    "policyAvatar": "",
    "welcomeMessage": "",
    "errorFields": {},
    "participantAccountIDs": [
        11665625
    ],
    "visibleChatMemberAccountIDs": [
        11665625
    ]
}

Why is it showing?

Solution

Investigate why the Expensify DM chat is showing in focus mode based on the report data above.

image
Issue OwnerCurrent Issue Owner: @situchan
@puneetlath puneetlath added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jun 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 14, 2024
@puneetlath puneetlath moved this to CRITICAL in [#whatsnext] #quality Jun 14, 2024
@dominictb
Copy link
Contributor

dominictb commented Jun 14, 2024

@puneetlath This is a dupe of #43599

@puneetlath
Copy link
Contributor Author

Ah got it! Closing!

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Development

No branches or pull requests

5 participants