[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Workspace - Workspace list reloads when returning online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42069

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Workspaces
3. Go offline
4. Go online

Expected Result:

Workspace list will not reload when returning online (production behavior)

Actual Result:

Workspace list reloads when returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

workspace.reload.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace list page shows loading indicator every time we come back online.

What is the root cause of that problem?

The workspace list page is wrapped with a withPolicyAndFullscreenLoading HOC which shows a loading indicator if the app is loading and the policy and policyDraft objects are empty.

App/src/pages/workspace/withPolicyAndFullscreenLoading.tsx

Lines 33 to 35 in 75c104b

	if (isLoadingReportData && isEmpty(policy) && isEmpty(policyDraft)) {
	return <FullscreenLoadingIndicator />;
	}

The policy object is from the withPolicy hook which gets the current policy data based on the policy ID route params. However, the workspace list page is a page to show the list of workspaces, so the current policy is always empty.

Why this happens now? It happens after this PR. In that PR, we update the default value to -1. So, when the policy ID param is empty, the value is -1. policy_-1.

App/src/pages/workspace/withPolicy.tsx

Lines 46 to 48 in 75c104b

	function getPolicyIDFromRoute(route: PolicyRoute): string {
	return route?.params?.policyID ?? '-1';
	}

Previously, it would fallback to an empty string, policy_ which would fetch the whole policy collection, which is definitely not what we want. So, that PR allows us to discover this hidden issue.

What changes do you think we should make in order to solve the problem?

We don't need withPolicyAndFullscreenLoading in WorkspacesListPage, so let's remove it.

[mountiny]

I can take over as its coming from a PR I have reviewed

[mountiny]

Thanks @bernhardoj, you will get partial compensation for helping identify the root cause!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove withPolicyAndFullscreenLoading from WorkspacesListPage #43818

If no regressions arise, payment will be issued on 2024-06-24. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove withPolicyAndFullscreenLoading from WorkspacesListPage #43818

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[mountiny]

For helping to identify the root cause and fix it, I propose a $50 reward to @bernhardoj, in line with similar cases elsewhere.

[kevinksullivan]

Payment summary:

• @bernhardoj $50 (paid in newdot)

[bernhardoj]

@kevinksullivan hi, I think I need to get paid in Upwork.

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$50 approved for @bernhardoj

[melvin-bot]

@kevinksullivan, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan, @mountiny Eep! 4 days overdue now. Issues have feelings too...