[$250] Expensify personal - Not here page opens when opening Expensify profile from group member list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat
3. Create a group chat with "Expensify"
4. Click on the group chat header > Members
5. Click Expensify
6. Click Profile

Expected Result:

Expensify profile will open without issue

Actual Result:

Not here page shows up when opening Expensify profile from group chat member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6515676_1718636209822.expppensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f91896edfd02fabc
• Upwork Job ID: 1820597582663880018
• Last Price Increase: 2024-08-19

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found page shows when opening the expensify account from group member list.

What is the root cause of that problem?

The profile page will show the not found page if the account is in the restricted account list and the expensify account is in that list (and the only one).

App/src/pages/ProfilePage.tsx

Line 144 in b335423

const shouldShowBlockingView = (!isValidAccountID && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

App/src/CONST.ts

Lines 2073 to 2076 in b335423

	// Account IDs that profile view is prohibited
	get RESTRICTED_ACCOUNT_IDS() {
	return [this.ACCOUNT_ID.NOTIFICATIONS];
	},

But previously, we can't create a group with an expensify account at all, but this PR now allows the expensify account to be shown in the new chat/search list result.

What changes do you think we should make in order to solve the problem?

We can hide the Profile button if the account is the restricted account.

App/src/pages/ReportParticipantDetailsPage.tsx

Lines 138 to 143 in b335423

	<MenuItem
	title={translate('common.profile')}
	icon={Expensicons.Info}
	onPress={navigateToProfile}
	shouldShowRightIcon
	/>

Or if we want to allow the user to see the expensify profile, then we need to remove the restricted account check here.

App/src/pages/ProfilePage.tsx

Line 144 in b335423

const shouldShowBlockingView = (!isValidAccountID && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

Or again, we can prevent the expensify account from being added to the group.

App/src/pages/NewChatPage.tsx

Lines 209 to 213 in 9ec57c0

	const itemRightSideComponent = useCallback(
	(item: ListItem & OptionsListUtils.Option) => {
	if (item.isSelfDM) {
	return null;
	}

if (item.isSelfDM || CONST.RESTRICTED_ACCOUNT_IDS.includes(item.accountID)) {
    return null;
}

notice there is another expensify account and we can add it to the restricted list if needed

[alexpensify]

I'll review this one soon.

[alexpensify]

No update yet

[alexpensify]

Still on my testing radar

[alexpensify]

Other GHs and customer tasks have been a higher priority, I'll get to this one soon.

[alexpensify]

Closing - I'm unable to replicate this experience by following the steps here

[alexpensify]

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.

If this GitHub needs an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

[bernhardoj]

@alexpensify hi, it's still reproducible, you need to create a group with [email protected]

aa.mp4

[alexpensify]

@bernhardoj I'm catching up from being OOO. I see the other GH mentioned here is closed too. Should we move this convo to a Slack 🧵 or keep this one closed? Thanks for the feedback!

[bernhardoj]

@alexpensify The other GH is closed because it's expected that Expensify is shown in the contact list which I mentioned in my proposal, but in this issue, opening the Expensify profile from the group members list page shows not found page. I think the first thing is to clarify what should be the expected behavior. There are 3 possible solutions (hide the profile button for Expensify, allow the user to see the Expensify profile, or not allow the user to add Expensify to a group) in my proposal. I think we can reopen this and assign an internal engineer to take a look and decide what should be the expected behavior.

[alexpensify]

OK, tomorrow, I'll start a discussion in the Slack room for more crowdsourced feedback.

[bernhardoj]

@alexpensify hi, is there any update with the discussion?

[alexpensify]

Reopening so this one doesn't slip out of my radar

[trjExpensify]

You shouldn't be able to Add to group the Chronos or Expensify users, so let's prevent that. Both are allowing me to select Add to group on them.

[trjExpensify]

@trjExpensify Just to confirm. Is the screenshot present in @bernhardoj 's proposal here #43841 (comment) is the UX expectation?

Yep, as the Add to group button is how you create a group, so we don't want to show the button.

[alexpensify]

@abdulrahuman5196 - are we good to go here or do you need more feedback from the team? Thanks for the update.

[melvin-bot]

@alexpensify, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Hi, Checking now

[abdulrahuman5196]

@bernhardoj 's proposal here #43841 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[iwiznia]

But previously, we can't create a group with an expensify account at all, but this PR now allows the expensify account to be shown in the new chat/search list result.

Asking here because I don't know why we did that.

[iwiznia]

Just to clarify, the part of the proposal we are doing is just this right?

Or again, we can prevent the expensify account from being added to the group.

Assuming the answer is yes and assigning @bernhardoj

[bernhardoj]

Just to clarify, the part of the proposal we are doing is just this right?

Yes

PR is ready. I also have a question about the expected results here

cc: @abdulrahuman5196 @trjExpensify @iwiznia

[alexpensify]

Next Steps

This PR is going through the review process and waiting for @iwiznia to final review it.

Heads up, I will be offline until Tuesday, September 3, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[alexpensify]

I'm catching up from being OOO last week and I see that this went into production yesterday. Seven days will be Monday, September 9.

[alexpensify]

Automation didn't kick in here, so I'll manually work on the process tomorrow.

[alexpensify]

Payouts due: 2024-09-09

• Contributor: $250 @bernhardoj
• Contributor+: $250 @abdulrahuman5196

Upwork job is here. I'll pay via Upwork because this one was created on June 17. Please accept and I can complete the payment process. Thanks!

[bernhardoj]

Accepted

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

#41290 (comment)

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Press FAB > Start Chat
2. Search for [email protected]
3. Verify there is no "Add to group" button for the account

@alexpensify accepted the offer

[alexpensify]

Closing - I've completed the payment process in Upwork.