-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Send invoice - "To" field displays Hidden instead of invoice receiver #43917
Comments
Triggered auto assignment to @slafortune ( |
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue."To" field displays Hidden instead of invoice receiver What is the root cause of that problem?When we calculate participants in case of invoice room here we do not pass What changes do you think we should make in order to solve the problem?We need to pass
What alternative solutions did you explore? (Optional)result.mov |
Job added to Upwork: https://www.upwork.com/jobs/~013c79d3cbeca420a5 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hidden user is shown in the To section of send invoice from a chat. What is the root cause of that problem?On the confirmation page, the participant is mapped from the transaction participant data. App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx Lines 139 to 149 in 904d49d
If the participant has an accountID, we map it with Lines 6651 to 6659 in 904d49d
With this information, we expect the participant to be mapped with
So, this condition thinks that the participant is a user.
What changes do you think we should make in order to solve the problem?We have 2 options:
|
@bernhardoj's proposal looks good to me! 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@slafortune, @Gonals, @thesahindia Eep! 4 days overdue now. Issues have feelings too... |
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR is ready cc: @thesahindia |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-17. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I'll request in ND once payment is due. |
Thanks for the heads up @bernhardoj - I closed the contract for this GH with Upworks |
It was caused by the migration PR . It was a huge PR, so it's easy to miss such cases. We don't need a specific test case here. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The payment should be due tomorrow (07-17) |
Requested in ND. |
@bernhardoj is due $250 for the Contributor role via NewDot |
$250 approved for @bernhardoj |
$250 approved for @thesahindia |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
"To" field will display the invoice receiver
Actual Result:
"To" field displays Hidden instead of invoice receiver
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
20240618_211242.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @slafortuneThe text was updated successfully, but these errors were encountered: