[HOLD for payment 2024-07-25] [$250] Expense - Tapping back button after deleting expense leads to not here page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Submit two manual expenses to any user.
3. Go to transaction thread of any expenses.
4. Tap on the report header.
5. Tap Delete expense.
6. Delete the expense.
7. Tap on the back button on the top left.

Expected Result:

App will return to the main page.

Actual Result:

App shows long skeleton loading and then not here page loads.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6521360_1719047106407.RPReplay_Final1719038925.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0149255b2b8a3385dc
• Upwork Job ID: 1805204830810844307
• Last Price Increase: 2024-06-24

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0149255b2b8a3385dc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[mountiny]

@bernhardoj is your fix going to work here too?

[mountiny]

I think we can demote this issue at this point. Its not blocking the user from using the app further, its quite specific edge case too

[mountiny]

Asked @cdOut to look into this as he worked on the details revamp

[bernhardoj]

@mountiny sorry, which one?

[yassinezaanouni]

I fixed the issue. I came from Upwork. Should I submit the proposal, or is there no need to now?

[iwiznia]

If I am understanding this correctly, it seems to me that they are basically the same problem and the fix applied here was incomplete. Your proposal is even in the same line as the PR in this issue changed and it's in the same flow.

@youssef-lr, @allroundexperts what do you think?

[kosmydel]

If I am understanding this correctly, it seems to me that they are basically the same problem and the fix applied here was incomplete. Your proposal is even in the same line as the PR in this issue changed and it's in the same flow.

This is not the same.

Previously, we were redirected to the page that was not found. Now, it briefly shows the not found page, when closing the RHP (but finally we are on the correct chat, previously we landed on not found). I'm not sure how we missed it during the testing and review. The RCA here sounds correct.

I can have a look at this, but I will probably have some results tomorrow, as I'm finishing my work for today soon.

[thienlnam]

Demoting again from this convo

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: back button after deleting expense #44537

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@allroundexperts can you have the checklist completed before EOD tomorrow? This will help avoid any delay in payment — thank you!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot

BugZero Checklist (@CortneyOfstad)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805204830810844307/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[CortneyOfstad]

@allroundexperts please complete the check list at your earliest convenience! Thank you!

[cdOut]

Hi, I just wanted to confirm, has this issue been properly fixed by this or another issue PR or are there still problems as pointed in this previous comment?

[allroundexperts]

Hi, I just wanted to confirm, has this issue been properly fixed by this or another issue PR or are there still problems as pointed in this previous comment?

The other issue was closed and fix was added here.

[allroundexperts]

Checklist

1. [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251
2. The author is aware of the issue and helped to review the fix in this issue.
3. N/A
4. A regression test would be helpful here.

Regression test

1. Open the app and submit two manual expenses to any user.
2. Go to transaction thread of any expenses.
3. Tap on the report header and select Delete expense.
4. Delete the expense.
5. Tap on the back button on the top left.

Verify that the app returns to the main page.

Do we 👍 or 👎 ?

[CortneyOfstad]

Payment Summary

@allroundexperts — to be paid $250 via NewDot

Regression Test

https://github.com/Expensify/Expensify/issues/416105

[JmillsExpensify]

$250 approved for @allroundexperts