[HOLD for payment 2024-07-24] Policy category - Add GL Code

[Gonals]

From the design doc:

settings/workspaces/{policyID}/categories/{categoryName}/gl-code -> CategoryGLCodePage
- Parameter: categoryName, the name of the category for which we are updating the GL code.
- Calls UpdateCategoryGLCode
policyID
categoryName - the name of the category for which we are updating the GL code.
glCode - the updated GL code for the category.
The pendingAction for the OfflineWithFeedback component will be policyCategory.pendingFields?.glCode

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[Gonals]

@rushatgabhane will be working on this

[rushatgabhane]

PR here: #43149

waiting for backend to deploy

[Christinadobrzyn]

Update for Melvin - monitoring PR - #43149

[Christinadobrzyn]

Update for Melvin - monitoring PR - #43149

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Christinadobrzyn]

PR in staging - #43149

@Gonals do we need to be concerned about this comment - #44255 (comment)

[rushatgabhane]

@Christinadobrzyn no, that is part of plan.
We are replacing it with Upgrade flow

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Policy category - Add GL Code #43149

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[Christinadobrzyn]

I don't think we need a regression test since this is a new feature, correct @rushatgabhane?

Payouts due:

• Contributor+: $250 @rushatgabhane (paid in NewDot)

[melvin-bot]

Payment Summary

Upwork Job

• Author: @rushatgabhane owed $250 via NewDot
• C+: @shubham1206agra owed $250 via Upwork (https://www.upwork.com/nx/wm/offer/103283703)

BugZero Checklist (@Christinadobrzyn)

Payment through NewDot so nothing done in Upwork

[Christinadobrzyn]

Payment day is here - payment summary - #44255 (comment)

I don't think we need a regression test for this since it's a new feature but let me know @rushatgabhane!

[rushatgabhane]

@Christinadobrzyn this will need a regression steps because we want to avoid future bugs.

[rushatgabhane]

Please assign @shubham1206agra as they were the C+ for the PR. @shubham1206agra will also help with the regression steps

I was the PR author

[JmillsExpensify]

$250 approved for @rushatgabhane

[Christinadobrzyn]

Just checking on this - #44255 (comment)

@shubham1206agra should you be paid for this as well? If yes, are you paid through Upwork or NewDot?

Can you create a regression test?

[shubham1206agra]

should you be paid for this as well?

Yes

If yes, are you paid through Upwork or NewDot?

Upwork

[shubham1206agra]

Can you create a regression test?

This might be covered in project test steps.

[Christinadobrzyn]

Thanks @shubham1206agra - here's the upwork offer - https://www.upwork.com/nx/wm/offer/103283703

Are you happy with these as the regression test steps:

1. Go to a collect policy
2. Go to category page
3. Select any category
4. Verify that you see GL Code
5. Verify that you can set a GL Code in the text input.
6. Verify that clicking save sets the GL Code and navigates you back

[shubham1206agra]

@Christinadobrzyn Offer accepted. And the test steps are good enough.

[Christinadobrzyn]

Regression test here - https://github.com/Expensify/Expensify/issues/416064

Paid @shubham1206agra in Upwork. Payment summary here - #44255 (comment)

Closing!