[HOLD for payment 2024-07-24] Tags - Add GL Code

[Gonals]

From the design doc:

settings/workspaces/{policyID}/tag/{orderWeight}/{tagName}/gl-code -> TagGLCodePage
- Parameter: orderWeight, for multi-level tags it is a number that denotes the order in which we display the tags. tagName, the name of the tag for which we are updating the GL code.
- Calls UpdateTagGLCode
policyID
tagListName - the name of the tagList where the updated tag is
tagListOrderWeight - the index of the tagList. It’ll make it simpler to find the tag in the DB.
tagName - the name of the tag for which we are updating the GL code. Tag name is unique for a given policy so we don’t need to pass orderWeight as an API parameter.
glCode - the updated GL code for the tag.
The pendingAction for the OfflineWithFeedback component will be policyTag.pendingFields?.glCode

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[Gonals]

@rushatgabhane will be working on this

[shawnborton]

What's the latest update here?

[Gonals]

The frontend is pretty much ready. Just waiting on the backend PRs to merge

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Tags - Add GL Code #43155

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[suneox]

I have reviewed the PR and reviewer checklist so can I have any compensation?

[muttmuure]

Seems fair

@rushatgabhane - C+ $250
@suneox - C+ $250

[muttmuure]

Invited you to https://www.upwork.com/jobs/~01fe5812aada936485

[suneox]

Invited you to https://www.upwork.com/jobs/~01fe5812aada936485

@muttmuure Thank you I have accepted

[rushatgabhane]

@suneox could you please add regression steps so this will work in future also

[suneox]

@suneox could you please add regression steps so this will work in future also

Yes I'll complete in few hours

[JmillsExpensify]

$250 approved for @rushatgabhane

[suneox]

Regression Test Proposal

• Precondition: Workspace must be upgraded to control policy, and tags must be enabled (WS setting -> more features -> tags).

1. Go to workspace settings (Profile -> Workspaces -> Select workspace -> Settings).
2. Open the Tags section.
3. Add a new tag then select it after adding.
4. Click on the GL Code section to update.
5. Fill in the GL Code and save.
6. Verify the tag is updated with the GL Code.

Do we agree 👍 or 👎

[muttmuure]

Offer sent @suneox

[suneox]

Offer sent @suneox

@muttmuure Thank you I have accepted an offer

[muttmuure]

Paid