[HOLD for payment 2024-08-19] [$250] User avatar and email does not show when using Submit it to someone to submit to a new user

[muttmuure]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.0-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation:

Action Performed:

Create an account on chrome.
Select Track and Budget Expense
Input your name, etc.
Global Create > Track Expense
Input the amount, description > Track
This will take you to your DM
Select Submit it to someone in the actionable whispers
Input the email
Submit it to them
It creates a weird DM where the avater is missing and their email
If I go back to home It also still looks like my DM but without the (you)
If I click into the erroneous DM, it then loads a proper DM where I submitted an IOU.

Expected Result:

The avatar and email of the user you've submitted an expense to shows in the new transaction comment

Actual Result:

The avatar and email are missing

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a44063017c2ea792
• Upwork Job ID: 1806345610575893571
• Last Price Increase: 2024-07-11
• Automatic offers:
• shubham1206agra | Reviewer | 103095829
• nkdengineer | Contributor | 103095831

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (AutoAssignerNewDotQuality)

[grgia]

Hey @Kicu do you think this is related to your avatar changes? Or is this due to the lack of accountID for an unknown user

[Kicu]

hey @grgia not sure about avatars yet, however what I know for sure is that I have not modified how an email would be displayed.
So if its both missing avatar AND missing email at the same time, my guess would be the root cause is some missing data.
And yes - if accountID would be missing we always display FallbackAvatar (which I guess was the expectation when doing avatars refactor 😄 )

[grgia]

And yes - if accountID would be missing we always display FallbackAvatar (which I guess was the expectation when doing avatars refactor 😄 )

Thanks @Kicu! This is what I was hoping to confirm. It seems like the main bug here is just the missing email/ defaulting to that instead of a blank first and last name. (Which we should have )

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a44063017c2ea792

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The avatar and email are missing when "Submit it to someone"

What is the root cause of that problem?

In here, it's using allPersonalDetails which is a local stored value.

Then in HeaderView here when getting report name it will use getDisplayNameForParticipant which uses getPersonalDetailsForAccountID which use allPersonalDetails above that is outdated in this case. Thus unable to get the personal detail of the optimistically added users and title will be empty and the loading will show.

What changes do you think we should make in order to solve the problem?

In

App/src/pages/home/HeaderView.tsx

Line 106 in ecb2000

const title = ReportUtils.getReportName(reportHeaderData);

, put personalDetails as the another param to getReportName (it goes without saying that if there's default params before it that's omitted when calling the method, we need to put default values for those params when calling, and only add personalDetails after that), then to getDisplayNameForParticipant and to getPersonalDetailsForAccountID

In getPersonalDetailsForAccountID, if personalDetails is inputted, use it here, and only uses allPersonalDetails if input personalDetails is not available.

This will make sure the HeaderView will always use the latest updated value of personalDetails to get the title.

The same fix can be added to other places if required.

What alternative solutions did you explore? (Optional)

[muttmuure]

@shubham1206agra please could you review @nkdengineer's proposal?

[melvin-bot]

@abekkala, @grgia, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[abekkala]

@shubham1206agra are you able to review the proposal above asap. thanks!

[shubham1206agra]

@nkdengineer's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[danielrvidal]

@muttmuure is this getting picked up soon? We're still experiencing this in the CVP flow? It feels like it should be a CRITICAL because it is an error in the core bottom up flow.

[muttmuure]

It's being worked on here: #45393

[muttmuure]

@grgia please could you make getting this out your top priority this week?

[danielrvidal]

I think this is now working for me, @muttmuure are you getting this with no error too?

[shubham1206agra]

@danielrvidal The PR was merged 10 hours ago.

[muttmuure]

Woohoo! Thanks @grgia, @shubham1206agra and @nkdengineer

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: User avatar and email does not show when using Submit #45393

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR AUG 19, if no regressions

• Fix: @nkdengineer [$250] OFFER
• PR Review: @shubham1206agra [$250] OFFER
  Please complete checklist

[abekkala]

@shubham1206agra can you complete checklist?

[abekkala]

@nkdengineer Payment sent and contract ended 🎉

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: [NoQA] feat: react-compiler #42287
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [NoQA] feat: react-compiler #42287 (comment)
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

@shubham1206agra payment sent and contract ended - thank you! 🎉