Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-01] [Free trial] [$250] Not able to get rid of Expensify Chat with a GBR in the LHN #44356

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 24, 2024 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.1-12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719247632996389

Action Performed:

  1. Open the app
  2. Observe the [email protected] chat in the LHN with GBR
  3. Click on it

Expected Result:

GBR should be able to be removed

Actual Result:

Unable to make that GBR chat to disappear

[email protected]:~$ getreport.sh 1539158347903228
Report 1539158347903228 is Open
State: 0: Open Status: 0: Open
Report:
created,submitted,approved,reportID,accountID,managerID,reportName,state,total,currency,status
"2024-04-26 18:11:24",,,1539158347903228,0,,"Chat Report",0,0,USD,0

Submitter:
accountID,email
0,fake

SharedReports:
accountID,reportID,permissions
11665625,1539158347903228,"read, write"
2536717,1539158347903228,read

ReportActions:
created,reportID,accountID,action,message,reportActionID
"2024-04-26 18:11:24.111",1539158347903228,0,CREATED,"{""creatorAccountID"":2536717,""lastModified"":""2024-04-26 18:11:24.111""}",3522208189545905848

ReportNVPs:
reportID,name,value
1539158347903228,chatType,system
1539158347903228,expensify_policyID,FAKE
1539158347903228,lastReadTime_11665625,"2024-04-26 18:11:24.111"
1539158347903228,lastReadTime_2536717,"2024-04-26 18:11:24.111"
1539158347903228,type,chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (23)

image (22)

Snip - (7) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e454a42dddd3d2f
  • Upwork Job ID: 1807772836439607453
  • Last Price Increase: 2024-07-15
Issue OwnerCurrent Issue Owner: @alexpensify
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify
Copy link
Contributor

I followed up in the Slack convo to figure out if this should be internal or external.

@alexpensify alexpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Jun 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 28, 2024
@alexpensify alexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@alexpensify
Copy link
Contributor

@OfstadC - The Slack 🧵 (HERE) concluded that there should be a live troubleshooting in Slack and then mark it as External. This morning, I had to deal with one of my managed customers, and that issue took my attention. I will be OOO until Monday, July 8, and I ran out of time to host the Slack troubleshooting. I'm reassigning the issue to avoid more delays. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Jul 1, 2024
@melvin-bot melvin-bot bot changed the title Not able to get rid of Expensify Chat with a GBR in the LHN [$250] Not able to get rid of Expensify Chat with a GBR in the LHN Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013e454a42dddd3d2f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@alexpensify
Copy link
Contributor

@CortneyOfstad - I'm going fully OOO now and noticed that another team member was running into this issue. I've assigned external but need help to keep pushing for proposals. Thanks!

@OfstadC
Copy link
Contributor

OfstadC commented Jul 1, 2024

@alexpensify You tagged the wrong sister 😅 . I'm also largely OoO this week, but will hopefully be able to move this forward before i'm out

@OfstadC
Copy link
Contributor

OfstadC commented Jul 2, 2024

Looks like we are waiting on proposals here. I'm OoO starting tomorrow for a few days. I think this still needs a status from Wave Collect curator - so i'll bump in Slack 😃 .

@kadiealexander is buddying for me if anything increases in priority while i'm out - but i'll be popping in occasionally

@OfstadC
Copy link
Contributor

OfstadC commented Jul 2, 2024

https://expensify.slack.com/archives/C036QM0SLJK/p1719954648424619

Copy link

melvin-bot bot commented Jul 4, 2024

@alexpensify, @OfstadC, @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2024
@suneox
Copy link
Contributor

suneox commented Jul 5, 2024

We’re still open to proposals. I’ve posted to Slack to get more eyes

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2024
@nyomanjyotisa
Copy link
Contributor

Any detailed steps to reproduce this issue ? I cant reproduce it. Even I cant see the Expensify Chat on the LHN on the latest main

Screenshot 2024-07-07 at 00 06 32

@chiragsalian chiragsalian self-assigned this Jul 16, 2024
@chiragsalian chiragsalian removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 16, 2024
@chiragsalian
Copy link
Contributor

I'll take over the issue since i investigated and know how to tackle it.

@trjExpensify trjExpensify changed the title [$250] Not able to get rid of Expensify Chat with a GBR in the LHN [Free trial] [$250] Not able to get rid of Expensify Chat with a GBR in the LHN Jul 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Jul 18, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@alexpensify
Copy link
Contributor

The PR is moving along through the required process.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot changed the title [Free trial] [$250] Not able to get rid of Expensify Chat with a GBR in the LHN [HOLD for payment 2024-08-01] [Free trial] [$250] Not able to get rid of Expensify Chat with a GBR in the LHN Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

  • @suneox requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jul 25, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@suneox] The PR that introduced the bug has been identified. Link to the PR:
  • [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@suneox] Determine if we should create a regression test for this bug.
  • [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 31, 2024
@alexpensify
Copy link
Contributor

@suneox - I sent an offer via Upwork. Please accept and I can continue the payment process tomorrow. Thanks!

https://www.upwork.com/jobs/~013e454a42dddd3d2f

@suneox
Copy link
Contributor

suneox commented Aug 1, 2024

@alexpensify I didn’t work on the PR and the reviewer’s checklist, so there’s no need to make a payment to me.

Copy link

melvin-bot bot commented Aug 1, 2024

Payment Summary

Upwork Job

  • ROLE: @suneox paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1807772836439607453/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@alexpensify
Copy link
Contributor

@suneox - thank you for your response. I'm going to close now and there is no payment summary here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

7 participants