[HOLD for payment 2024-07-24] [$50] Rip out the beta code for REPORT_FIELDS

[thienlnam]

We're no longer using the code for CONST.BETAS.REPORT_FIELDS. This is enabled for everyone internally - so we can just remove the beta code related to CONST.BETAS.REPORT_FIELDS

Note: This is different from the beta REPORT_FIELDS_FEATURE

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108e03ca805bf2401
• Upwork Job ID: 1806686959271564355
• Last Price Increase: 2024-06-28
• Automatic offers:
• c3024 | Reviewer | 102919536
• neonbhai | Contributor | 102919537

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0108e03ca805bf2401

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Upwork job price has been updated to $50

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the beta code for REPORT_FIELDS

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

We will remove the code corresponding to canUseReportFields beta checks, and its uses in the app

App/src/libs/Permissions.ts

Lines 18 to 20 in 0c8bae5

	function canUseReportFields(betas: OnyxEntry<Beta[]>): boolean {
	return !!betas?.includes(CONST.BETAS.REPORT_FIELDS) || canUseAllBetas(betas);
	}

[c3024]

@neonbhai can be assigned.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@thienlnam, @neonbhai, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Report Fields Beta #44695

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

@thienlnam, @bfitzexpensify, @neonbhai, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

cc @bfitzexpensify Could we handle payment here?

$50 to @neonbhai and @c3024.

No regression tests needed for this

[bfitzexpensify]

Payments complete. Closing this out