[HOLD for payment 2024-08-01] [$250] Wallet : Incorrect padding on "we're reviewing..." label

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719470547378329

Action Performed:

1. Go to staging.new.expensify.com
2. Go to settings > Wallet
3. Enable Wallet
4. Notice the message "we're reviewing your information, please check back in a few minutes!"

Expected Result:

There should be no padding issue or too much indent

Actual Result:

Message has too much indentation and we should remove the horizontal padding

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016598836022b81a73
• Upwork Job ID: 1811437561354747333
• Last Price Increase: 2024-08-01
• Automatic offers:
• ShridharGoel | Contributor | 103132371

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet : Incorrect padding on "we're reviewing..." label

What is the root cause of that problem?

alertViewStyle has ph5 style, and it is being used below which adds the extra horizontal padding.

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 440 to 464 in cd72f1b

	if (isPendingOnfidoResult) {
	return (
	<View style={alertViewStyle}>
	<Icon
	src={Expensicons.Hourglass}
	fill={theme.icon}
	/>
	<Text style={alertTextStyle}>{translate('walletPage.walletActivationPending')}</Text>
	</View>
	);
	}
	if (hasFailedOnfido) {
	return (
	<View style={alertViewStyle}>
	<Icon
	src={Expensicons.Exclamation}
	fill={theme.icon}
	/>
	<Text style={alertTextStyle}>{translate('walletPage.walletActivationFailed')}</Text>
	</View>
	);
	}

What changes do you think we should make in order to solve the problem?

ph5 is not needed here, we can remove it:

const alertViewStyle = [styles.flexRow, styles.alignItemsCenter, styles.w100, styles.ph5];

[ShridharGoel]

@shawnborton Is it happening always, any idea why it's marked as "Needs reproduction"?

[shawnborton]

I think because you need to go through a US wallet enablement flow to trigger it. But as long as we can force the condition on the front end to test, I think we'll be okay.

[ShridharGoel]

@muttmuure Can you have a look?

[muttmuure]

Hm, I don't think I can do this easily. I'm not a US resident so I can't queue this up

[ShridharGoel]

So can someone else be assigned as BZ ?

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

Shawn helped me with the above! I hadn't validated my Expensify account yet.

I was able to reproduce the padding issue. I got a different message, and the padding was still incorrect:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016598836022b81a73

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix padding in wallet onfido messages #45631

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @ShridharGoel requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Not overdue, payment is due tomorrow.

@eVoloshchak can you please handle the BZ checklist? Thanks!

[sakluger]

While I agree that this change wouldn't normally pay $250, I'm actually going to switch the price back to $250 on this one since the Upwork offer was sent before changing the price.

[melvin-bot]

Upwork job price has been updated to $250

[sakluger]

Summarizing payment on this issue:

Contributor: @ShridharGoel $250, paid via Upwork
Contributor+: @eVoloshchak $250, please request on Newdot

[sakluger]

@eVoloshchak please complete the BZ checklist so we can close this one out. Thanks 🙏

[sakluger]

Bumped on Slack.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: [CP staging] Prevent second attempts to activate wallet when Onfido checks fail #30114
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30114/files#r1704440630
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, additional discussion isn't needed

Regression Test Proposal

1. Go to Expensify app.
2. Go to settings > Wallet.
3. Enable Wallet -> Go through the process of adding a bank account
4. Notice the message "We're reviewing your information, please check back in a few minutes!".
5. Verify there is no extra padding, text is aligned with the balance above

Do we agree 👍 or 👎

[sakluger]

Thanks! I created the issue to add new regression test steps.

[JmillsExpensify]

$250 approved for @eVoloshchak