Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] Temporarily hide GBP on the Add payment card and Change payment currency screens. #44852

Closed
trjExpensify opened this issue Jul 4, 2024 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Jul 4, 2024

Coming from here.

We've hit a couple of a snags with getting the 3DS/SCA flow working to support adding GBP payment cards. Let's de-risk that blocking the release of the Subscription page, by temporarily removing GBP in the currency selector on the Add payment card and Change payment currency screens.

Once we've fixed the issues stemming from #44795, we can add GBP back.

Issue OwnerCurrent Issue Owner: @trjExpensify
@trjExpensify trjExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jul 4, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 4, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Temporarily hide GBP on the Add payment card and Change payment currency screens. [HOLD for payment 2024-07-17] [Payment card / Subscription] Temporarily hide GBP on the Add payment card and Change payment currency screens. Jul 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Payment card / Subscription] Temporarily hide GBP on the Add payment card and Change payment currency screens. [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] Temporarily hide GBP on the Add payment card and Change payment currency screens. Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 16, 2024
@trjExpensify
Copy link
Contributor Author

No C+ on this one, closing.

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants