[$250] Pay someone - Unapprove option is available for "Pay someone" expense, which gives error

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.5-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any DM.
3. Go to + > Pay someone.
4. Enter amount and pay them.
5. Click on the expense preview.
6. Click on the report header..
7. Click Unapprove.

Expected Result:

Unapprove option should not be available for "Pay someone" expense.

Actual Result:

Unapprove option is available for "Pay someone" expense, which results in error.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6535832_1720443170610.20240708_205102.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010702f689c6b7150e
• Upwork Job ID: 1826736492231832841
• Last Price Increase: 2024-08-22

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[Beamanator]

@rushatgabhane looks like we gotta fix this!

[Beamanator]

PR up soon

[Beamanator]

Fix merged & CPing

[Beamanator]

Done 'n dusted, should be fixed as of 9.0.5-6 👍

[ishpaul777]

Can we please reopen to complete payment for PR #45049

[Beamanator]

There's 3 app PRs listed in that PR, we only need to handle payment in 1 of those - so I was thinking we'll do that in a different one, not this one

[ishpaul777]

@Beamanator Can we reopen any of those please : D

[Beamanator]

Aah yep looks like @ishpaul777 hasn't been paid for reviewing #45049 🙏 @MitchExpensify can you please help with that? 🙏

[Beamanator]

asked for payment help internally

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010702f689c6b7150e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[mallenexpensify]

ah.. shit, sorry @Pujan92 , forgot to assign @ishpaul777 BEFORE adding External.

@ishpaul777 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~010702f689c6b7150e

[ishpaul777]

I have accepted the offer 🙏 Thank you! @mallenexpensify

[mallenexpensify]

Contributor+: @ishpaul777 paid $250 via Upwork.

@ishpaul777 we want a regression test for this, right? Assuming so, can you fill out the checklist? Thx

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@] The PR that introduced the bug has been identified. Link to the PR:
• [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@] Determine if we should create a regression test for this bug.
• [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: [Unapprove] Add unapprove feature to approved reports  #44229
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44229/files#r1731407999
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@ishpaul777] Determine if we should create a regression test for this bug. - Yes
• [@ishpaul777 ] If we decide to create a regression test for the bug, please propose the [regression test] - (https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md) steps to ensure the same bug will not reach production again.

Regression Test proposal -

• Open Newdot
• Go to any DM.
• Go to + > Pay someone.
• Enter amount and pay them.
• Click on the expense preview.
• Click on the report header.

Expected Result:

Unapprove option should not be available for "Pay someone" expense report.

Do we agree 👍 or 👎 ?

[mallenexpensify]

Thanks @ishpaul777 test case GH created

• https://github.com/Expensify/Expensify/issues/423317