Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] Add copy report onyx object to clipboard function on dev/staging #44994

Closed
puneetlath opened this issue Jul 8, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Jul 8, 2024

In order to make troubleshooting easier, let's add a new option to the right-click/long-press menu on reports in the LHN. The new option will be called Copy Onyx data and it will only be visible on dev/staging.

Clicking on it will copy the Onyx data for the report object onto the user's clipboard. Without opening the report.

image

Issue OwnerCurrent Issue Owner: @puneetlath
@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 8, 2024
@puneetlath puneetlath self-assigned this Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2024
@ShridharGoel
Copy link
Contributor

ShridharGoel commented Jul 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add copy report onyx object to clipboard function on dev/staging

What is the root cause of that problem?

New feature.

What changes do you think we should make in order to solve the problem?

Add a new option to ContextMenuActions.tsx.

Logic on pressing the option:

const report = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
Clipboard.setString(JSON.stringify(report));

shouldShow should be true when type === CONST.CONTEXT_MENU_TYPES.REPORT and env is dev/staging.

{
    isAnonymousAction: false,
    textTranslateKey: 'reportActionContextMenu.copyOnyxData',
    icon: Expensicons.Copy,
    successIcon: Expensicons.Checkmark,
    shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID, isPinnedChat, isUnreadChat) =>
        type === CONST.CONTEXT_MENU_TYPES.REPORT && isDevelopment(), // Can add staging check also.
    onPress: (closePopover, {reportID}) => {
        const report = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
        Clipboard.setString(JSON.stringify(report));
    },
    getDescription: () => {},
},
Screen.Recording.2024-07-09.at.12.02.55.AM.mov

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 8, 2024
@TMisiukiewicz
Copy link
Contributor

I'm Tomasz from Callstack and I'd like to work on this issue

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Jul 9, 2024

@puneetlath It's a simple change, can it be made external? I've added a proposal above.

@cdOut
Copy link
Contributor

cdOut commented Jul 9, 2024

Hi, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I'll be working on this issue.

@puneetlath
Copy link
Contributor Author

@ShridharGoel I'd like to get it out fast, so working with an agency contributor on it directly. That's why I didn't mark it external. Thanks for your interest though!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 9, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Jul 10, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title Add copy report onyx object to clipboard function on dev/staging [HOLD for payment 2024-07-24] Add copy report onyx object to clipboard function on dev/staging Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

  • @cdOut does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@cdOut] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jul 23, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Jul 23, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@puneetlath
Copy link
Contributor Author

I believe @sobitneupane needs to be paid here. Right @sobitneupane?

@sobitneupane
Copy link
Contributor

Yes @puneetlath. I reviewed the PR linked with this issue.

@puneetlath
Copy link
Contributor Author

Payment summary:

Please request on NewDot @sobitneupane

@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Jul 26, 2024
@JmillsExpensify
Copy link

$250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

6 participants