[PAID][Search v2.1][Web-E] Deprecate old Search params

[luacmartins]

Implement this section of the design doc.

Holding on:

• Use new Search query syntax when calling api #46481

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

Still on hold

[JmillsExpensify]

We're good to review the hold, yeah?

[luacmartins]

Not yet, the holding PR is still in draft

[slafortune]

Just in case - adding another BZ - I'll be out until 8/21 and will check in on this then.

[luacmartins]

That PR is not related to this issue. I still haven't worked on this one.

[luacmartins]

Since this is all internal, I'll unassign you from this issue.

[brunovjk]

@luacmartins I reviewed the PR, which has now been in production for a week. However, I wasn't assigned to the issue or involved in the proposal review. Should I be assigned to this issue for compensation, or given the simple nature of the PR, can we close the issue and move on? Thank you.

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

@brunovjk I updated the issue to make sure we process payment for the PR review. Thanks for raising this!

[brunovjk]

Thank you 🙏

[strepanier03]

Sent an offer to @brunovjk - I'll check tomorrow to issue payment.

[strepanier03]

Payment summary

• $250 - @brunovjk via Upwork (offer)

[brunovjk]

Regression Test Proposal

• Open the search page.
• Select "Transactions."
• Open your browser console.
• Click on "Download."
• Verify that the API request to ExportSearchToCSV includes jsonQuery in the payload.

Do we agree? 👍 or 👎

[luacmartins]

No need to add the steps above, we're covering them as part of the project wrap up.

[strepanier03]

Thanks @luacmartins, was just going to close the GH and saw you took care of that too, appreciate it!

[strepanier03]

All right, I've paid and closed the contract and this is ready to be closed as well. Thanks everyone!