-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Details revamp] No option to cancel payment for paid expense as 3-dot menu is removed #45077
Comments
Triggered auto assignment to @Gonals ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
This was caused by the PR I worked on from the Details Revamp that removed the 3-dot menu, it must've been something that we overlooked while testing during the removal. I will create a PR that re-adds this feature into the Details page. |
To clarify, I thought that we already added these buttons in some PR before working on 3-dot menu removal PR and that PR was only to remove the menu. Is it correct @cdOut? |
@parasharrajat I've looked back and no, this button was never considered in the design doc nor was it included anywhere in the issue descriptions / discussion threads that we did. We have added others for deleting, booking a call etc. but this one was missed during considerations. |
I'll focus on getting a PR up for this one as soon as possible. |
@cdOut, how is this going? |
@Gonals I've created a PR for it and moved it to review. |
#45130 (comment) QA worked well in staging |
Can we close out this issue as the PR for it has been merged? |
Payment summary as follows:
Feel free to request, closing! |
$250 approved for @allroundexperts |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.5-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
There should be an option to cancel payment. On prod, cancel payment option is accessible from 3-dot menu
Actual Result:
There is no option to cancel payment for paid expense as 3-dot menu is removed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6536793_1720525601263.20240709_194230.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: