[HOLD for payment 2025-01-21] [$250] Track- Error appears when Submit expense to someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4704990&group_by=cases:section_id&group_order=asc&group_id=309130
Email or phone of affected tester (no customers): [email protected]

Action Performed:

1. Login with new account
2. Go to Self DM> Track expense
3. Submit the expense to someone
4. Wait for a minute

Expected Result:

There should be no errors and submitted expense should be present on LHN and report

Actual Result:

Red dot and error appears after Submit expense to someone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536104_1720537021906.ae7d5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01408041e16e8fde12
• Upwork Job ID: 1815525298284767197
• Last Price Increase: 2024-08-08
• Automatic offers:
• CyberAndrii | Contributor | 105455137

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[alexpensify]

This one is on my testing list. I'll review it soon.

[melvin-bot]

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

No update, I'll test soon

[alexpensify]

Other GHs have been a priority, I'll review soon

[alexpensify]

I was able to replicate the experience in my Android application

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01408041e16e8fde12

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[alexpensify]

We need proposals here.

[melvin-bot]

@alexpensify @Pujan92 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[alexpensify]

Open for proposals here

[alexpensify]

I'm moving to Weekly since things will be a little slower this week. @blimpich, when you are back online, can you please review this one? Thanks!

[blimpich]

The proposal looks very promising to me as well!

Before removing the parameter, I think it is needed to verify on the API side to ensure that the receipt parameter is not required in any scenario for ConvertTrackedExpenseToRequest, CategorizeTrackedExpense, and ShareTrackedExpense.

Can confirm it is not required at all for ConvertTrackedExpenseToRequest, and it's optional for CategorizeTrackedExpense and ShareTrackedExpense. Going to assign @CyberAndrii to this 👍

One question @CyberAndrii. Your proposal says this breaks for the tracked case and for the distance request case correct? We definitely should not be sending anything for the receipt file in the distance request, so can you fix it for both the tracked case and the distance case?

[melvin-bot]

📣 @CyberAndrii 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

Heads up, I will be offline until Friday, January 3, 2025, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[alexpensify]

Weekly Update: PR is ready for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[blimpich]

@CyberAndrii @Pujan92 looks like we had to revert? What are the next steps here? Are we waiting on #54358?

[CyberAndrii]

@blimpich All good. It was a partial revert and re-implementation in a different way.

But QA is having trouble testing this due to an unrelated issue. Commented here.

#54358 is also unrelated. They just wanted to confirm if the merge conflicts were resolved correctly.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix error on Android when submitting a tracked expense #54628

If no regressions arise, payment will be issued on 2025-01-21. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment through NewDot Manual Requests
• @pasyukevich does not require payment (Contractor)
• @CyberAndrii requires payment automatic offer (Contributor)

[melvin-bot]

@Pujan92 @alexpensify @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]