[HOLD for payment 2024-07-22] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to workspace chat
3. Submit some expenses
4. Click on the expense preview
5. Go back and forth between main chat, expense report and expense thread

Expected Result:

App will not flicker when switching between expense reports

Actual Result:

App flickers when switching between expense reports
On Android, keyboard is dismissed when trying to focus on the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537869_1720617424375.Android.mp4

Bug6537869_1720617424384.RPReplay_Final1720609502.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ddb1dcdf7db2cf6
• Upwork Job ID: 1811353829124565469
• Last Price Increase: 2024-07-12

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[danieldoglas]

I don't think this is related to backend, removing the DeployBlocker tag

[izarutskaya]

@danieldoglas Also the app is flickering when a new user finishes the onboarding flow. It flickers again after tapping on the "Get started" button. The issue can't be reproduced with the same account after this.
Let me know please if we need to create a new issue. Thanks

Bug6538707_1720686908936.PTZT3012.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013ddb1dcdf7db2cf6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

The one PR that modified text input behaviour seems unlinked, but it would be worth testing out just to be sure.

[rushatgabhane]

The one PR that modified text input behaviour seems unlinked, but it would be worth testing out just to be sure.

tested. its unrelated

[danieldoglas]

Maybe lets's check reverting #45120 and #45120

@rushatgabhane @allgandalf

[kavimuru]

@Julesssss Issue fixed in iOS

RPReplay_Final1721051515.MP4

[Julesssss]

The final check will be to verify the Android keyboard issue. As this workflow is currently broken on main I am generating a manual workflow build here.

[Julesssss]

Verified the fix here on Android. Checking it off 🤩

[mountiny]

$500 to @allgandalf for their help with testing and reviewing

$125 to @ikevin127 for their help identifying the offending commit, @kirillzyusko do you think this means that the react-compiler has somehow changed the memoization of that file or what could be the RCA? @ikevin127 mentioned that for them the problem was resolved reverting before that commit

[allgandalf]

This should be Hold for payment @mountiny , the PR was CP'ed to staging

[kirillzyusko]

do you think this means that the react-compiler has somehow changed the memoization of that file or what could be the RCA?

@mountiny Well, I don't think so, because I tried to disable react-compiler at all and the issue was still there 🤷‍♂️

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: frequent component re-mount #45335

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

can someone please update the date for payment it should be [HOLD for payment 2024-07-22] instead :))

[garrettmknight]

Thanks @Julesssss !

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: [CP Staging] Add freezeScreenWithLazyLoading function #44544

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44544/files#r1682508572

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

I don't really think a regression test is needed here, this happened in an normal flow, like opening the compose.

But do let me know if we need a test at all, would be happy to provide :))

[allgandalf]

This is ready for payment today @garrettmknight , thanks :)

[ikevin127]

Payments summary: #45152 (comment).

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @ikevin127 paid $125 via Upwork
• Reviewer: @allgandalf paid $500 via Upwork

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1811353829124565469/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct