Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-16] Invoice balance section #45179

Closed
madmax330 opened this issue Jul 10, 2024 · 21 comments
Closed

[HOLD for payment 2024-10-16] Invoice balance section #45179

madmax330 opened this issue Jul 10, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@madmax330
Copy link
Contributor

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#bookmark=id.rrjlhda54yy
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 2, 2024

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37 rezkiy37 mentioned this issue Aug 5, 2024
50 tasks
@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 5, 2024

I've implemented the raw balance section. Continue working.

Details Screenshot 2024-08-05 at 17 05 57

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 6, 2024

Actively working on the issue.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 8, 2024

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 8, 2024

I am attaching examples of how it works and looks like.

cc @madmax330

Details

Success

Success.mp4

Disabled

Disabled

Error

Error

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2024

Actively working on the PR.

@danielrvidal
Copy link
Contributor

Any updates on this one? I think this needs to be done for SuiteWorld by Sept 9th as well but am not sure.

@danielrvidal danielrvidal moved this from Low to Critical in [#whatsnext] #billpay Aug 27, 2024
@rezkiy37
Copy link
Contributor

Discussion in Slack.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Sep 3, 2024

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

@rezkiy37
Copy link
Contributor

Hello!
I am OOO from 19.09 - 23.09. I will continue to work on this one when I am back. Meanwhile, @waterim will work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 25, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 9, 2024
@melvin-bot melvin-bot bot changed the title Invoice balance section [HOLD for payment 2024-10-16] Invoice balance section Oct 9, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 9, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

  • @rezkiy37 does not require payment (Contractor)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 16, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@madmax330 madmax330 added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@madmax330
Copy link
Contributor Author

@OfstadC for this one can you just do the C+ review payment for @akinwale ?

@OfstadC
Copy link
Contributor

OfstadC commented Oct 17, 2024

Sure! Just to confirm we'll need to issue $500 (I see this is a Critical issue) to @akinwale . Is that correct @madmax330 ? 😃

@madmax330
Copy link
Contributor Author

It's $250

@OfstadC
Copy link
Contributor

OfstadC commented Oct 17, 2024

Thanks @madmax330

@OfstadC
Copy link
Contributor

OfstadC commented Oct 17, 2024

@akinwale Offer sent here 😃

@OfstadC
Copy link
Contributor

OfstadC commented Oct 17, 2024

Payment Summary

@OfstadC OfstadC closed this as completed Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Critical to Done in [#whatsnext] #billpay Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants