[HOLD for payment 2024-08-05] [$250] Expense - Inconsistency in expense preview when deleting tracked expense & submitted expense offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4700344
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to self DM.
4. Track an expense in self DM.
5. Delete the tracked expense in self DM.
6. Note that the expense preview is crossed out.
7. Go to DM with any chat.
8. Submit an expense to the user.
9. Delete the expense.

Expected Result:

The expense preview will be crossed out when deleting expense offline. The behavior will be consistent with deleting tracked expense in self DM offline.

Actual Result:

The expense preview is not crossed out when deleting expense offline. This is not consistent with deleting tracked expense in self DM offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6538323_1720642157986.20240711_040528.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a18b3786ddabfcdd
• Upwork Job ID: 1813279573925986534
• Last Price Increase: 2024-07-16
• Automatic offers:
• ishpaul777 | Contributor | 103144778
• nyomanjyotisa | Contributor | 103164028

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in expense preview when deleting tracked expense & submitted expense offline

What is the root cause of that problem?

App/src/components/ReportActionItem/ReportPreview.tsx

Line 375 in abbe80d

<Text style={styles.textHeadlineH1}>{getDisplayAmount()}</Text>

we don't add line-through here if the action is deleted like here

What changes do you think we should make in order to solve the problem?

Add styles.lineThrough if is deleted here

const isDeleted = action?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

<Text style={[styles.textHeadlineH1, isDeleted && styles.lineThrough]}>{getDisplayAmount()}</Text>

What alternative solutions did you explore? (Optional)

If we want to strikethrough everything for both track expense and submit expense:

1. Add styles.lineThrough if is deleted to the Submit Expense preview texts here and here

const isDeleted = action?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

<Text style={[styles.textHeadlineH1, isDeleted && styles.lineThrough]}>{getDisplayAmount()}</Text>

<Text style={[styles.textLabelSupporting, styles.lh16, isDeleted && styles.lineThrough]}>{getPreviewMessage()}</Text>

2. Add styles.lineThrough if is deleted to the Track Expense preview first text here

<Text style={[styles.textLabelSupporting, styles.flex1, styles.lh16, isDeleted && styles.lineThrough]}>{getPreviewHeaderText()}</Text>

RESULT

Submit expense preview

Track expense preview

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The expense preview is not crossed out when deleting expense offline. This is not consistent with deleting tracked expense in self DM offline.

What is the root cause of that problem?

• In here, we do not add:

                pendingFields: {
                    preview: 'delete',
                }

when the iou report will be deleted.

• So our pendingAction in here:
  

  App/src/components/ReportActionItem/ReportPreview.tsx

  Line 326 in 58e2575

  pendingAction={iouReport?.pendingFields?.preview}

  
  is empty so there is no line-through applied.

What changes do you think we should make in order to solve the problem?

• We should add:

                pendingFields: {
                    preview: 'delete',
                }

to here.

What alternative solutions did you explore? (Optional)

• We can also update this:
  

  App/src/components/ReportActionItem/ReportPreview.tsx

  Line 326 in 58e2575

  pendingAction={iouReport?.pendingFields?.preview}

  
  to:

           pendingAction={iouReport?.pendingFields?.preview || action.pendingAction}

Optional:

• We can also make the similar change to MoneyRequestPreviewContent component by updating:
  

  App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

  Line 300 in a2f29e5

  <OfflineWithFeedback

  
  to:

            <OfflineWithFeedback
                pendingAction={action.pendingAction}
                shouldDisableStrikeThrough={!isDeleted}
                shouldDisableOpacity={!isDeleted}

[melvin-bot]

@MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a18b3786ddabfcdd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[MitchExpensify]

Reassigning as I'm heading on leave 🙇

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ishpaul777]

@tienifr your solution doesn't seem to work for me, you might have mistakenly gave wrong link. Also for the alternative solution, i think we only want strikethrough style on amount like in track expense case not on all text

[ishpaul777]

@nyomanjyotisa's proposal sound good and works as expected 👍

🎀 👀 🎀 C+ reviewed

[ishpaul777]

@tienifr would you format your main solution to match #45247 (comment) behaviour, just for clarity

[tienifr]

@ishpaul777 My proposal already matched that comment

[ishpaul777]

Oh you put it in optional, sorry my bad.

I am changing my recommendation since we aligned to apply strikethrough style on everything inside IOU and REPORTPREVIEW action when deleted optimistically.

@puneetlath please assign @tienifr 🙇

Sorry @nyomanjyotisa i think for new behavior tienifr's solution is better

[tienifr]

PR #45758 is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: strike through IOU and REPORTPREVIEW once delete #45758

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment automatic offer (Contributor)
• @tienifr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@ishpaul777 bump on the checklist please.

[ishpaul777]

On my list will complete today 🙇

[ishpaul777]

[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: I could not find a specific PR that introduced this bug. blame history didn't help this was like this from the begining, i think we should not block it on this.
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ishpaul777] Determine if we should create a regression test for this bug.- Yes
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open newdot
2. Go offline.
3. Go to self DM.
4. Track an expense in self DM.
5. Delete the tracked expense in self DM.

Expected Result:

The tracked expense preview will be crossed out when deleting expense offline

6. Go to DM with any chat.
7. Submit an expense to the user.
8. Delete the expense.

Expected Result:

The expense preview will be crossed out when deleting expense offline

Do we agree 👍 or 👎 ?

[puneetlath]

Payment summary:

• C+ - $250 - @ishpaul777 - paid via Upwork
• C - 250 - @tienifr - to be paid via NewDot

Thanks everyone!

[garrettmknight]

$250 approved for @tienifr