[HOLD for payment 2024-08-01] [$125] Add note to clarify the workspace join link functionality

[mountiny]

### Problem

Coming from here, we have agreed that on the workspace share page, we do not provide enough details for the admin about what the link/QR code does.

The link will allow users to join the workspace upon visiting while being signed in. A message will appear in the admins room for each join request to confirm the addition (unless its a domain controlled account in which case we pre-approve the requests but I think we can omit that information).

Solution

Lets add some message to the share page that will make this clear, maybe with some icon/ illustration too

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015304db5f2b46c0a1
• Upwork Job ID: 1811770909332799477
• Last Price Increase: 2024-07-12
• Automatic offers:
• dominictb | Contributor | 103094166
• DylanDylann | Contributor | 103815612

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @shmaxey (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[shawnborton]

Double design assignment, pow!

This should be a quick one once we have the correct copy though!

[shawnborton]

cc @Expensify/design - here is a quick mock to get us started:

Figma link is here

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Add note to clarify the workspace join link functionality

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

• We should add the note to above line:

<View style={[themeStyles.mh5, themeStyles.mv1]}>
                            <Text style={[themeStyles.textNormal, themeStyles.mt2]}>{'Easily share your workspace with other members'}</Text>
                        </View>
                        <View style={[themeStyles.mh5, themeStyles.mv1]}>
                            <Text style={[themeStyles.textNormal, themeStyles.mt2]}>
                                {
                                    'Share this QR code or copy the link below to make it easy for members to request access to your workspace. All requests to join the workspace will show up in the '
                                }
                               <TextLink
                                    style={themeStyles.link}
                                    onPress={() => {
                                        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminRoom))
                                    }}
                                >
                                    {'#admin'}
                                </TextLink>
                                {' room for your review.'}
                            </Text>
                        </View>

• The style can be modified and the adminRoom can be get like we did in this:
  

  App/src/pages/workspace/WorkspacesListPage.tsx

  Line 183 in 58e2575

  onSelected: () => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(item.adminRoom ?? '')),

What alternative solutions did you explore? (Optional)

[shmaxey]

That copy lgtm!

[dubielzyk-expensify]

That looks good to me 👍

[mountiny]

@shawnborton seems like we are good here with the design and the copy, are we good to move ahead?

[shawnborton]

Nice! Let's move forward then ⏩

[dannymcclain]

Looks good to me too! Way more clear ❤️

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015304db5f2b46c0a1

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: add note to clarify the workspace join link functionality #45374

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dominictb] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[miljakljajic]

payment due tomorrow, not overdue

[miljakljajic]

@dominictb will we need a regression test?

[dominictb]

@miljakljajic I don't think we need regression test.

[miljakljajic]

paid in upwork

[DylanDylann]

@miljakljajic I reviewed this PR. Should I get compensation for this issue?

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

$125 to @DylanDylann too

[miljakljajic]

Thanks for flagging @mountiny !

@DylanDylann - accept the offer and we'll pay right away. Apologies for not catching this.

[DylanDylann]

@miljakljajic Done, thanks for helping 🙏

[miljakljajic]

Paid! :)