Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting text with a blank line underneath it shows grey text, unable to send message using Enter key #45345

Closed
2 of 6 tasks
m-natarajan opened this issue Jul 12, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.6-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720744680218859

Action Performed:

Type a message with a word then a blank space under it
Copy the text and space then send message
Paste the text and space into the compose box
Expected Result:
Actual Result: Text is grey and can't send

Expected Result:

Text and space to show as black/normal text and able to send the messge

Actual Result:

Text is grey and can't send using Enter key

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-07-11_17-28-34.mp4
Recording.321.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @brunovjk
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 12, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jul 12, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 12, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Jul 12, 2024
@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 12, 2024
@mountiny
Copy link
Contributor

I think its a specific flow with a workaround for the user, the live markdown library is tough to update, we cannot just CP aa library update and we need to deploy so at this state we should demote imho.

@Skalakid @BartoszGrajdek @tomekzaw for visibility

We could apply some patch though temporarily

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jul 12, 2024
Copy link

melvin-bot bot commented Jul 12, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 12, 2024
Copy link

melvin-bot bot commented Jul 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

@dangrous
Copy link
Contributor

Yeah agree that I don't think this needs to be a blocker. Would be great if the live markdown experts have a fix! Seems pretty easy to add a test for too once it's updated.

@mallenexpensify
Copy link
Contributor

Mentioned in Slack but doesn't look like it carried over, I found while testing the below, which might be related

@Skalakid
Copy link
Contributor

Skalakid commented Jul 15, 2024

@m-natarajan @dangrous @mallenexpensify I can't reproduce this issue on the latest main, can you check if it still occurs? I think #44958 might have fixed it

Screen.Recording.2024-07-15.at.19.41.31.mov

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@brunovjk
Copy link
Contributor

brunovjk commented Jul 15, 2024

Screen.Recording.2024-07-15.at.19.41.31.mov

I also couldn't reproduce (2024-07-15 / v9.0.6-8 ), I have the same result as the video above.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

@dangrous, @OfstadC, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dangrous
Copy link
Contributor

yes this seems fixed for me as well! I'm going to close - but @mallenexpensify if you're still getting it, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

7 participants