[$500] [Medium] TRIPPREVIEW is not showing the preview/info

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C05S5EV2JTX/p1720621730730619

Action Performed:

1. Book a trip in spotnana
2. Navigate to the workspace chat

Expected Result:

Preview should load/show info

Actual Result:

Preview is not reliably loading/showing information

https://files.slack.com/files-pri/T047TPA624F-F07BMUQ00P8/screenshot_2024-07-10_at_7.58.02___pm.png

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f530c69599f191f
• Upwork Job ID: 1812949990970484758
• Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Given the urgency, I've opted to assign this to the engineers curating the #travel-gbta-july-22-2024 project. Please reassign as needed!

[johncschuster]

Bumping Slack for proposals

[twisterdotcom]

Hmm, I thought that would double it.

[b4s36t4]

Reproduction steps are unclear, is there any video to demonstrate the issue clearly?!

[johncschuster]

@b4s36t4 I see you requested in Slack to be added to the beta. I've just done that now.

[b4s36t4]

@johncschuster hitting issue as mentioned here #45647

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@iwiznia, @johncschuster, @danieldoglas, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Thanks for the heads up, @b4s36t4! I'll keep an eye on that issue as well.

[kevinksullivan]

Hi @b4s36t4 can you try again?

[cristipaval]

Not overdue, Melv

[melvin-bot]

@iwiznia, @johncschuster, @cristipaval, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cristipaval]

I'm working on a PR to block creating trip rooms for the pre-paid bookings until the payment is confirmed.

[johncschuster]

Not overdue. @cristipaval's working on a PR

[cristipaval]

Spotnana finally replied to my questions, here

[cristipaval]

The Auth PR is ready for review.

[cristipaval]

Fix PR hit production. Closing

[shubham1206agra]

Hello @cristipaval

I am sorry for asking this
But am I eligible for compensation here?
Since I originally reported the issue https://expensify.slack.com/archives/C05S5EV2JTX/p1720621730730619
And I tried to drive this issue here https://expensify.slack.com/archives/C05S5EV2JTX/p1725546707583219

[cristipaval]

@johncschuster could you please check the above comment? 🙏

[johncschuster]

@shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?

If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!

[shubham1206agra]

@shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?

If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!

@johncschuster Did both, but there are a lot of places where we discussed this in Slack (some are in private DMs). One thread I found is in #45348 (comment)

[johncschuster]

Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?

[shubham1206agra]

Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?

Not really. Since the fix was made internally.

[cristipaval]

I also participated in that Slack thread, where we chatted about the steps to reproduce the issue. I think we usually do a partial pay when the C+ reviews proposals before we decide to take the issue internally. We also do this when we accept a proposal, the contributor starts working on it, and then we decide to close the issue or fix it internally. Other than the bug report in Slack, I can't tell concrete contributions from @shubham1206agra to the solution, @johncschuster, so I'm not sure if the #bug-zero team pays anything in these situations.