Update app modal does not display

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Receive an app-update notification on desktop
2. Click on the notification.

Expected Result:

An modal is displayed asking if you want to update and restart the app.

Actual Result:

The app is focused, but no modal is displayed. The user must use the app menu to update.

Workaround:

Use the app menu to update:

Platform:

• Desktop App

Version Number: 1.0.83.0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[roryabraham]

I believe this regression was most likely caused by #4406, but haven't confirmed.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Shouldn't have included the AutoAssignerTriage label, my bad @jboniface.

[roryabraham]

@alex-mechler observed this bug on desktop v1.0.81-6, which means that it's present on production. Demoting this from deploy blocker to regular bug...

[alex-mechler]

Also going to drop to a daily instead of hourly, but I still think this is quite important

[parasharrajat]

This is caused by a break-in in the Onyx architecture. #4500

[alex-mechler]

@parasharrajat Can you explain the connection a little more? I'm not seeing how that causes this, but it might.

[parasharrajat]

ok. @alex-mechler

1. For users who have once received the update will set the ONYKEYS.UPDATE_AVAILABLE to true.
2. We have an issue in Onyx where if the value does not change, Onyx will not trigger an update notification to the component.
3. Each time you start the app, we ignore (initWithStoredValues: false) the stored value of ONYKEYS.UPDATE_AVAILABLE which is already true as you once received the update.
4. Now on next time you receive the update, Set ``ONYKEYS.UPDATE_AVAILABLE` to true which will not have any effect as Onyx will not set the notification to UpdateModal component, and thus component will never be shown.

[alex-mechler]

Ah okay that makes more sense! Thanks for the explanation. It looks like we are actively working on that issue then, so does it make sense to wait to see if that Onyx fix fixes this issue?

[parasharrajat]

Yes

[parasharrajat]

I have added the fix #4604. Please watch out if that fixes it.

[alex-mechler]

This has not happened to me again since that PR went out to staging. Thanks @parasharrajat!