[HOLD #47534][$250] Xero - Strange animation after dismissing 2FA setup RHP and not here page on LHN

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44059
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has a workspace.
• The workspace is connected to Xero.
• User has not set up 2FA.

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Log in to the account from precondition.
4. Click Enable two-factor authentication.
5. Click the back button on 2FA set up RHP.
6. Navigate between Account settings, Search and Inbox.

Expected Result:

App should throw 2FA set up modal again if user exits 2FA set up flow.

Actual Result:

In Step 5, when clicking on back button on 2FA setup RHP, the RHP dismissal has a weird animation.
In Step 6, after switching between sections, not here page shows up on the left hand panel.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544785_1721201414390.20240717_152508.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2d69ad81006978f
• Upwork Job ID: 1813578824903964216
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

Commented on the offending PR #44059

[rushatgabhane]

The issue is present after reverting this PR too. its unrelated to the PR and related to navigation

[MonilBhavsar]

Ok thanks for checking!

[MonilBhavsar]

The issue is present after reverting this PR too.

@rushatgabhane if we revert this PR, then the 2FA modal doesn't show up and looks like issue is not reproducible?

[rushatgabhane]

@MonilBhavsar let me rephrase what i mean - this same issue is present on production also. The PR above did not make any changes to how back navigation was handled

1. Go to production - https://new.expensify.com/settings/security/two-factor-auth?backTo=home
2. Click back

Screen.Recording.2024-07-17.at.17.12.45.mov

[MonilBhavsar]

Ok thanks for clarifying. Makes sense

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2d69ad81006978f

[melvin-bot]

@MonilBhavsar, @ahmedGaber93, @VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too...

[ahmedGaber93]

@VictoriaExpensify I think we need to add monthly label because we hold it for monthly issue #47534

[melvin-bot]

@MonilBhavsar, @ahmedGaber93, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ahmedGaber93]

@VictoriaExpensify bump #45572 (comment)

[melvin-bot]

@MonilBhavsar, @ahmedGaber93, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ahmedGaber93]

@VictoriaExpensify bump #45572 (comment)

[MonilBhavsar]

Adjusted label, thanks!

[melvin-bot]

@MonilBhavsar, @ahmedGaber93, @VictoriaExpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[trjExpensify]

I don't think this should be closed, it's held on #47534 so I've updated the title to reflect that better to follow the breadcrumbs.

[ahmedGaber93]

#49539 was deployed to production 4 days ago #49539 (comment), the navigation issue looks fixed

20250221030621480.mp4

After the navigation issue was fixed, we can focus on the expected Result now

App should throw 2FA set up modal again if user exits 2FA set up flow.

@VictoriaExpensify Can you please confirm the expected Result?