Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Date of birth - No minimum age limit on date of birth #45852

Closed
6 tasks done
lanitochka17 opened this issue Jul 20, 2024 · 6 comments
Closed
6 tasks done

Profile - Date of birth - No minimum age limit on date of birth #45852

lanitochka17 opened this issue Jul 20, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Profile
  3. Click Date of birth

Expected Result:

There should be a minimum age limit on date of birth
For example, previously the app behavior is that user cannot pick date of birth earlier than 5 years

Actual Result:

There is no minimum age limit on date of birth

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547935_1721467985686.20240720_172804.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 20, 2024
Copy link

melvin-bot bot commented Jul 20, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@etCoderDysto
Copy link
Contributor

etCoderDysto commented Jul 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

No minimum age limit on date of birth

What is the root cause of that problem?

Minimum age CONST.DATE_BIRTH.MIN_AGE used here is 0

inputID={INPUT_IDS.DOB}
label={translate('common.date')}
defaultValue={privatePersonalDetails?.dob ?? ''}
minDate={subYears(new Date(), CONST.DATE_BIRTH.MAX_AGE)}
maxDate={subYears(new Date(), CONST.DATE_BIRTH.MIN_AGE)}

What changes do you think we should make in order to solve the problem?

Update the MIN_AGE used here to the desired number. Example 5

MIN_AGE: 0,

What alternative solutions did you explore? (Optional)

@Krishna2323
Copy link
Contributor

I think this is expected behaviour introduced in this PR.

cc: @dukenv0307

@melvin-bot melvin-bot bot added the Overdue label Jul 23, 2024
@kadiealexander
Copy link
Contributor

Agree, this is expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants