Deploy Checklist: New Expensify 2024-07-23

[github-actions]

Release Version: 9.0.11-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense. #43794
• clear policy errors #44130
• feat: release-profiler on web #44432
• fix: Subscription size - Decimal point can be inserted and not removed on the confirmation page. #44507
• fix: Scan - No error pop-up and scan expense with corrupted PDF can be submitted via QAB  #44778
• fix: optimistically add report field for all expense reports #44894
• Missing Save & continue button on 'Choose your bank account' #45040
• [Report Next Steps Audit] Simplify the App optimistic next steps #45160
• fix The tag and category lists lack consistent alphabetical order #45236
• focus trap modal config initial focus #45366
• feat: add note to clarify the workspace join link functionality #45374
• fix: Search icon has no safe area around and its hard to tap. #45380
• [No QA] Card settings page #45415
• compiler: allow mutating refs in certain components #45464
• use isSmallScreenWidth only at the chid component DecisionModal #45465
• Fix invoice thread opens when starting DM with the user after sending invoice to them #45500
• Fix short mention isn't recognized when editing a message #45504
• [#Wave-Control: Add NetSuite] Added auto focus for all NetSuite forms #45507
• fix: remove categorize page from navigation stack #45560
• fix: only display last 4 digits #45598
• Composer: add clear command that bypasses the event count #45613
• Fix padding in wallet onfido messages #45631
• fix: A new user can navigate away from the onboarding #45661
• fix Report fields still appear on the expense report when the feature is disabled #45668
• merge duplicate emojis on frequently used #45671
• Fix can't close account of a new created account #45673
• fix: displaying export button #45678
• Only show entity menu item if there are entities to select #45679
• Format message for olddot action #45683
• [No QA] Empty state modal #45690
• [Wave Collect][Xero] Enforce 2FA for xero #45702
• Feature: Create Deactivate card logic #45703
• New report param hasReceivedFreeTrialEndMessage check #45723
• Fix blue border appears on workspace switcher button after login #45743
• Fix no background when creating money request #45746
• remove duplicate api calls on wallet page load #45759
• Fixed NetSuite access variant #45761
• Bump react-native-live-markdown to 0.1.107 #45767
• Settings - Left hand menu and RHP do not open instantly when opening from link #45778
• Show pin and message option for current user profile #45783
• Update Netsuite-Troubleshooting.md #45792
• Consolidate and combine accounting terms for reimbursable and non-reimbursable export destinations #45795
• Freetrial time fix #45798
• Create Set-Up-NetSuite-connection.md #45802
• Update CONTRIBUTING.md #45804
• Create Set-Up-Sage-Intacct-connection.md #45807
• [HelpDot] add redirect for .html extension #45808
• Fix header Set-Up-Sage-Intacct-connection.md #45809
• Fix "Hidden" report shows in LHN after dismissing RBR in the main chat #45817
• Fix randomly selected for review system message shown as html/markdown #45819
• fix workspace name showing previous name #45820
• Update Quickbooks-Desktop-Troubleshooting.md #45871
• Update Connect-To-QuickBooks-Desktop.md #45872
• [ImgBot] Optimize images #45880
• [No QA] Update doc following Ren feedback #45903
• fix: improve getDisplayNameForParticipant performance #45907
• [NoQA] compiler: --json option to healthcheck CLI #45915
• Update Netsuite-Troubleshooting.md #45933
• Update Configure-Netsuite.md #45934
• [No QA] update onyx field to use correct attribute #45943
• Update Configure-Sage-Intacct.md #45963
• Revert "fix: Web - Split - Enter and CMD+Enter open user profile instead of splitting expense." #45964
• Update Connect-To-Accelo.md #45973
• Update Configure-Accelo.md #45974
• [CP Staging] Revert "Composer: add clear command that bypasses the event count" #46056
• [CP Staging] Revert "Merge pull request #44432 from margelo/feat/release-profiler-on-web" #46070
• Fix app crashes when connecting to Xero #46087
• Don't show the export option in threads #46141
• [No QA] Fix prod web deploys #46152

Deploy Blockers:

• [$250] Thread - App shows join button after user joined offline #46004
• Thread - App signs out user after leaving thread #46007
• Android & iOS - Composer - Selected emoji is not shown in the composer after sending message #46024
• [HOLD for payment 2024-08-19] [$250] Xero - Onboarding modal shows up after refreshing page with 2FA setup prompt #46026
• [HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] Xero - App crashes when connecting to Xero #46039
• [Workspace Feeds] Expensify Card - Expensify Card page reopens when clicking Back from workspace editor #46045
• [HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] Desktop - App - App font is different on staging #46048
• [HOLD for payment 2024-08-07] [$250] Workspace - Profile page is not grayed out when workspace is created offline and name is edited #46053
• Self DM - Self DM does not show up on new Expensifail accounts #46055
• Search - Unable to hold expense from Search and console error shows up after trying to hold it #46061
• [HOLD for payment 2024-08-09] [$250] Categorizing - Page blinks after selecting a category during categorization #46063
• [$250] mWeb – Chat – Blue frame appears around Back button if navigate via search to Concierge chat #46075
• Search - Hold option is present for expense that is still scanning on Search page #46078
• [HOLD for payment 2024-08-14] [Workspace Feeds] Sage intacct - "Expensify Card Settlement Account" Link does not redirect #46083
• Threads - Pin icon doesn't disappear right after user leaves a thread #46084
• [HOLD for payment 2024-08-09] [$250] Threads - Leaving from multilevel threads navigates to wrong thread #46085
• [HOLD for payment 2024-08-19] [$125] Threads - User is allowed to navigate to thread notification preference via URL #46097
• [HOLD for payment 2024-08-09] [$250] Workspace - Invited member is allowed to upload workspace avatar, but the upload fails #46098
• AU-Troubleshoot-Tapping reset &refresh shows onboarding modal &directs to concierge #46101
• [Workspace Feeds] Expensify Card - Reconciliation account link directs to hmm not here page #46108
• [$250] mWeb – Chat – Blue frame appears around + button when open conversation link URL in a new tab #46109
• [HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent #46110
• [HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] Xero Export - Export button appears for message threads that are in the expense report #46138

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.11-0 🚀

[rlinoz]

Checking off #46024, tested the CP and it fixed the issue.

[mvtglobally]

Regression is at 35% completed

Blockers
#46004
#46026
#46045
#46048
#46053
#46061
#46063

[francoisl]

Demoting #46026 - edge case and not breaking any functionality
Demoting #46083 - beta
#46070 tested on staging, checking off

We're working on the remaining blockers.

[roryabraham]

Demoting #46063

[marcaaron]

Demoting #46084

[marcaaron]

Demoting #46075

[francoisl]

Demoting #46053
Checking #45464, no QA
Checking #45703, no QA steps

[francoisl]

3 blockers left at the moment, one has a fix merged waiting for a cherry-pick

---

The following PRs still need to QA:
#45366
#45160
#45507
#45631
#45678
#45679
#45683
#45702 - this is blocked on #46039 now, but should be fixed once #46087 gets cherry-picked
#45761
#45778
#45795
#45820

[mvtglobally]

Regression is at 2% left

Unchecked PRs
#45160 - Pending validation on all platforms
#45366 - Issue when executing #46060. repro in PROD. Checking off
#45507 - Pending validation on all Desktop, Android, IOS. On Web/mWeb issue #46062. Repro in PROD.
#45631 - Pending validation on all platforms
#45679 - Pending validation on all platforms
#45683 - Pending validation on all platforms
#45702 - this is blocked on #46039 now, but should be fixed once #46087 gets cherry-picked
#45703 (comment)
#45778 - Pending validation on all platforms
#45795 - Pending validation on all platforms

Blockers
#46004
#46039
#46085
#46097
#46108
#46109
#46110

[francoisl]

#46087 tested on staging, checking off with blocker #46039
Demoting #46109 - minor style issue
Demoting #46110
Demoting #46097
Demoting #46004 - non-critical offline flow

[mvtglobally]

Regression is at last 1% left

Unchecked PRs
#45160 - Pending validation on all platforms
#45507 - Pending validation on all Desktop, Android, IOS. On Web/mWeb issue #46062. Repro in PROD.
#45631 - Pending validation on Desktop, rest are pass
#45679 - Pending validation on all platforms. Can you pls check #45679 (comment)
#45702 - this is blocked on #46039 now, but should be fixed once #46087 gets cherry-picked
#45703 (comment)
#45795 - Pending validation on all platforms

open Blockers
#46085
#46138

[mvtglobally]

Regression is Completed

Unchecked PRs
#45160 - Pending validation on all platforms. quite long one
#45507 - is failing #46062. Repro in PROD, checking off

#45679 - Pending validation on all platforms. We are blocked #45679 (comment)
#45702 - this is blocked on #46039 Are we good to retest?
#45703 (comment) - seems Pass on web
#45795 - Pending validation on IOS / Android

open Blockers
#46085
#46138

[francoisl]

#45702 - this is blocked on #46039 Are we good to retest?

yes you can retest 45702 now. Thanks!

[francoisl]

Fix #46138 tested on staging, checking off
Checking off 45160 - some backend problems on staging are preventing from confirming updates received from Pusher anyway
#45795 - checking - it was mostly some text update and it was verified on web and desktop already
#46085 is repro on prod (The web production deploy wasn't working, that's why we thought it was not repro in prod, but now it is)
#45679 - checking off, QAed myself

[mvtglobally]

@francoisl pls double check #46157. It is sort of a new feature, so I didnt add a Blocker label, but it is not reproducible in PROD.

[francoisl]