Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-05] [TS] Memoize utility instance lacks typings for cache property #46069

Closed
kacper-mikolajczak opened this issue Jul 23, 2024 · 6 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@kacper-mikolajczak
Copy link
Contributor

kacper-mikolajczak commented Jul 23, 2024

Details

This is a known regression, which originates from #43868

Instance of memoize module lacks correct typings for cache property. Methods of cache (get, set, etc.) have key parameter typed as unknown.

Steps to reproduce

  1. Create an instance of memoize by calling memoize method
  2. Check the typings of cache property methods on the instance

Expected behaviour

key argument in cache methods matches arguments of memoized function

Actual behaviour

key argument is set to unknown

Screenshot 2024-07-23 at 22 03 03
@kacper-mikolajczak
Copy link
Contributor Author

I will work on this!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot changed the title [TS] Memoize utility instance lacks typings for cache property [HOLD for payment 2024-08-05] [TS] Memoize utility instance lacks typings for cache property Jul 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 5, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
@kacper-mikolajczak
Copy link
Contributor Author

I think we can close this one, right @mountiny?

@mountiny
Copy link
Contributor

Yep, thanks!

@melvin-bot melvin-bot bot removed the Overdue label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants