[$250] [Payment card / Subscription] "Change payment card" button doesn’t work after using 3DS flow to add GBP payment card

[blimpich]

Problem

After adding a payment card using the 3DS flow we can't change the payment card.

Screen.Recording.2024-07-24.at.2.38.12.PM.mov

Solution

Figure out why and fix it.

Note:

You will need to use an internal Expensify engineer's ngrok credentials in order to test this. If you'd like to work on this please message @blimpich and I will provide you with instructions on how to use my local backend via ngrok. One of the catches with this is that my ngrok will only work when I'm online, so if you aren't able to be online during some portion of PST 9am-5pm hours then you might not want to work on this.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016cee3d2a1a851762
• Upwork Job ID: 1819499472402209186
• Last Price Increase: 2024-08-02
• Automatic offers:
• nkdengineer | Contributor | 103423143

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[blimpich]

This really should be external I think, but non-Expensify engineers can't actually repro this issue until #46144 is completed, since the full 3DS flow isn't available to them locally (link). So marking this as internal hot pick for now.

[trjExpensify]

Could we send it external and let them connect to someone's VM or something like we've done before?

[blimpich]

Even with access to an engineer's ngrok a external contributor won't be able to repro this. I'm working on this which I think should make it possible for external engineers to repro this with a Expensify engineer's ngrok credentials.

[muttmuure]

Held on solution in linked issue

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[blimpich]

I think I've figured out a way to make this work with my local VM, so that contributors can just use my ngrok. I was having difficulty with contributors using flows that used Web-Secure but I think I have this working now. So lets mark this as external and see if anyone can fix it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016cee3d2a1a851762

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

waiting for proposals here

[nkdengineer]

You will need to use an internal Expensify engineer's ngrok credentials in order to test this

@blimpich I'd like to work on this issue. Can you share your ngrok then I can test and find a solution, thanks.

[blimpich]

DM'ed @nkdengineer with credentials on Slack.

[melvin-bot]

@hungvu193 @muttmuure @nkdengineer this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[nkdengineer]

I'm working on this issue now

[hungvu193]

Still working on the PR.

[nkdengineer]

Currently, to test this PR, I need the Blimpich environment, and we need to be online at the same time, but we're in different regions. Will try to test it tonight.

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[blimpich]

Not sure why I wasn't assigned to this before, ignore the ping @lakchote

[hungvu193]

This issue was deployed to prod 8 days ago, it's now ready for payment @muttmuure

[muttmuure]

$250 - @hungvu193
$250 - @nkdengineer

[garrettmknight]

$250 approved for @hungvu193

[muttmuure]

@nkdengineer paid