-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-11] [$150] Expense - Combined report is more grayed out than the transaction thread #46200
Comments
Triggered auto assignment to @dylanexpensify ( |
Edited by proposal-police: This proposal was edited at 2024-08-15 11:53:52 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.
App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 148 to 179 in 4adf0c5
What is the root cause of that problem?
App/src/components/ReportActionItem/MoneyRequestView.tsx Lines 473 to 489 in 4adf0c5
What changes do you think we should make in order to solve the problem?
<View>
{transactionThreadReport && !isEmptyObject(transactionThreadReport) ? (
<>
<OfflineWithFeedback pendingAction={action.pendingAction}>
<MoneyReportView
report={report}
policy={policy}
isCombinedReport
shouldShowTotal={transactionCurrency !== report.currency}
shouldHideThreadDividerLine={shouldHideThreadDividerLine}
/>
</OfflineWithFeedback>
<ShowContextMenuContext.Provider value={contextValue}>
<View>
<MoneyRequestView
report={transactionThreadReport}
shouldShowAnimatedBackground={false}
/>
{renderThreadDivider}
</View>
</ShowContextMenuContext.Provider>
</>
) : (
<OfflineWithFeedback pendingAction={action.pendingAction}>
<MoneyReportView
report={report}
policy={policy}
shouldHideThreadDividerLine={shouldHideThreadDividerLine}
/>
</OfflineWithFeedback>
)}
</View> What alternative solutions did you explore? (Optional)
const getPendingFieldAction = (fieldPath: TransactionPendingFieldsKey) => pendingAction ? undefined : transaction?.pendingFields?.[fieldPath]
ResultMonosnap.screencast.2024-07-25.20-47-05.mp4 |
Edited by proposal-police: This proposal was edited at 2024-08-07 11:17:24 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The combined report is more grayed out than the transaction thread What is the root cause of that problem?In the combined report, we wrap the
But in the transaction thread report, we don't do it here App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 106 to 108 in 4adf0c5
And in
What changes do you think we should make in order to solve the problem?We should wrap the component here with App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 106 to 108 in 4adf0c5
We also need to return the pending field action here as undefined if the
OPTIONAL: We can also wrap the receipt label and receipt empty state with OfflineWithFeedback
We also need to update and then also use
We also need to do the same way for What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.Combined report is more grayed out than the transaction thread What is the root cause of that problem?When displaying the report we wrap it with App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 148 to 150 in 4adf0c5
But when displaying it in transaction thread we don't wrap it with App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 105 to 115 in 4adf0c5
What changes do you think we should make in order to solve the problem?wrap it with
What alternative solutions did you explore? (Optional) |
Proposal Updated
|
Updated proposal #46200 (comment) to add alternative solution. |
Proposal Updated
|
@dylanexpensify Eep! 4 days overdue now. Issues have feelings too... |
@dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
reviewing today! |
Job added to Upwork: https://www.upwork.com/jobs/~010079feefd518ffb7 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
Upwork job price has been updated to $125 |
External, but lowered price for ease of fix |
Updated proposal with another fix in the main solution. |
Thanks for your proposals. @Krishna2323 Your proposal will work, but it cause the inconsistency between other components like @nyomanjyotisa Your solution is incorrect since it can cause the double greyed out problem So I like the way to keep things consistent like @nkdengineer's solution, we should remove the fallbackPendingAction and wrap receipt label and receipt empty state with OfflineWithFeedback Let's go with @nkdengineer's solution 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@dylanexpensify BTW, The issue can be easy to fix, but finding a consistent solution that doesn't cause any regression is not too easy. Should we keep the initial price (250$) as usual? Thanks |
@dukenv0307, I don't think that's the case. For instance, we can look at the Monosnap.screencast.2024-08-08.11-02-08.mp4App/src/pages/home/report/ReportActionItemContentCreated.tsx Lines 137 to 146 in 4adf0c5
|
Upwork job price has been updated to $150 |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
pending hitting prod the 7 day period |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-11. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Coming up! |
Payment summary: Contributor: @nkdengineer $150 Please apply/request! |
@nkdengineer @dukenv0307 please accept offers! |
BugZero Checklist:
Regression test:
|
bump @dukenv0307 @nkdengineer on accepting contract |
@dylanexpensify Sorry I missed that, I accepted the contract |
Done! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The grayness of the combined report and the transaction thread should be the same
Actual Result:
The combined report is more grayed out than the transaction thread
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6552519_1721902826735.bandicam_2024-07-25_18-16-58-090.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dylanexpensifyThe text was updated successfully, but these errors were encountered: