-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Hybrid app: Welcome video shows out-dated copy "Request money" #46334
Comments
Triggered auto assignment to @sakluger ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Welcome video and text shows out-dated copies. What is the root cause of that problem?The video being used needs to be updated. Line 4183 in 5e65276
What changes do you think we should make in order to solve the problem?The internal team would upload a new video. Then, We can also update the |
cc @Expensify/design do you manage changes to the welcome video referenced here? |
cc @jamesdeanexpensify since we were talking about this today in Slack. Yes @sakluger - design can handle these sorts of things with TCW. But let's wait and see what James says first, I think we have plans to redo some of this stuff already in the works? |
Hmm...the feedback I gave was in this thread and created this GH. Outside of that, I didn't have anything in the works! |
Ah got it, I was thinking of this comment here that you had made today |
@sakluger Do we plan to make this external? Then, once the updated videos and text is available, then it can be implemented. |
@ShridharGoel I don't think we plan on making this external. @shawnborton can you confirm that I should label this as internal? |
We'll need to update the videos internally first, but we might be switching things up here with different welcome videos based on intent, so let's hold here for a moment until we decide. But once we have updated videos, then we can make it external to implement the changes. |
I put this issue on hold since it sounds like we'll likely be making bigger changes to the videos. If we end up moving forward with those bigger changes, I suggest we close this issue. |
@shawnborton any thoughts on long-term plans around our welcome videos? If we have near or mid-term plans to update our welcome videos, then we should close this GH issue. If we don't plan to make changes anytime soon, then we should probably change the copy in this video. |
@anmurali @dubielzyk-expensify @danielrvidal thoughts on Sasha's comment above? |
Great call. I think we're looking at removing it because we have intent specific videos, but I'll let Anu or Daniel remind me if I'm wrong |
@anmurali @danielrvidal any thoughts on this one? When are we planning on making the intent-specific videos? Just trying to get a sense on whether we should update the current video, or close this GH issue for now in favor of waiting for the new videos. |
I don't think that video is in the flow anymore so I think it's fine to close. We removed the general welcome from the new user flow. Additionally, I think @JmillsExpensify is working on a new welcome video that we'll show to existing users coming over but that would be outside of this issue. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721943528361069
Action Performed:
NVP.set('tryNewDot', {classicRedirect: {dismissed: "true"}});
Expected Result:
The video shows "Submit expense" and how to use it
Actual Result:
It shows the out-dated terminology/copy of "Request money", which is not present in the product at all now.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: