Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Hybrid app: Welcome video shows out-dated copy "Request money" #46334

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 26, 2024 · 15 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Not a priority

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721943528361069

Action Performed:

  1. Set the NVP on expensify.com with the snippet NVP.set('tryNewDot', {classicRedirect: {dismissed: "true"}});
  2. Log in to the hybrid app
  3. Open the menu at the top left
  4. Click Try New Expensify
  5. Watch the welcome video

Expected Result:

The video shows "Submit expense" and how to use it

Actual Result:

It shows the out-dated terminology/copy of "Request money", which is not present in the product at all now.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@ShridharGoel
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome video and text shows out-dated copies.

What is the root cause of that problem?

The video being used needs to be updated.

App/src/CONST.ts

Line 4183 in 5e65276

WELCOME_VIDEO_URL: `${CLOUDFRONT_URL}/videos/intro-1280.mp4`,

What changes do you think we should make in order to solve the problem?

The internal team would upload a new video. Then, WELCOME_VIDEO_URL needs to be updated on FE.

We can also update the onboarding.explanationModal.description text since that also contains old terminology.

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@sakluger
Copy link
Contributor

cc @Expensify/design do you manage changes to the welcome video referenced here?

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@shawnborton
Copy link
Contributor

cc @jamesdeanexpensify since we were talking about this today in Slack.

Yes @sakluger - design can handle these sorts of things with TCW. But let's wait and see what James says first, I think we have plans to redo some of this stuff already in the works?

@jamesdeanexpensify
Copy link
Contributor

Hmm...the feedback I gave was in this thread and created this GH. Outside of that, I didn't have anything in the works!

@shawnborton
Copy link
Contributor

Ah got it, I was thinking of this comment here that you had made today

@ShridharGoel
Copy link
Contributor

@sakluger Do we plan to make this external? Then, once the updated videos and text is available, then it can be implemented.

@sakluger
Copy link
Contributor

@ShridharGoel I don't think we plan on making this external. @shawnborton can you confirm that I should label this as internal?

@shawnborton
Copy link
Contributor

We'll need to update the videos internally first, but we might be switching things up here with different welcome videos based on intent, so let's hold here for a moment until we decide. But once we have updated videos, then we can make it external to implement the changes.

@sakluger sakluger changed the title Hybrid app: Welcome video shows out-dated copy "Request money" [HOLD] Hybrid app: Welcome video shows out-dated copy "Request money" Aug 1, 2024
@sakluger sakluger added Monthly KSv2 and removed Daily KSv2 labels Aug 1, 2024
@sakluger
Copy link
Contributor

sakluger commented Aug 1, 2024

I put this issue on hold since it sounds like we'll likely be making bigger changes to the videos. If we end up moving forward with those bigger changes, I suggest we close this issue.

@sakluger
Copy link
Contributor

sakluger commented Sep 4, 2024

@shawnborton any thoughts on long-term plans around our welcome videos? If we have near or mid-term plans to update our welcome videos, then we should close this GH issue. If we don't plan to make changes anytime soon, then we should probably change the copy in this video.

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@shawnborton
Copy link
Contributor

@anmurali @dubielzyk-expensify @danielrvidal thoughts on Sasha's comment above?

@dubielzyk-expensify
Copy link
Contributor

Great call. I think we're looking at removing it because we have intent specific videos, but I'll let Anu or Daniel remind me if I'm wrong

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@sakluger
Copy link
Contributor

sakluger commented Oct 7, 2024

@anmurali @danielrvidal any thoughts on this one? When are we planning on making the intent-specific videos? Just trying to get a sense on whether we should update the current video, or close this GH issue for now in favor of waiting for the new videos.

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@danielrvidal
Copy link
Contributor

I don't think that video is in the flow anymore so I think it's fine to close. We removed the general welcome from the new user flow. Additionally, I think @JmillsExpensify is working on a new welcome video that we'll show to existing users coming over but that would be outside of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

7 participants