[HOLD for payment 2024-08-14] [$250] mWeb - Workpace - Creating workspace via plus icon shows inconsistent behavior in mweb and Android

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.13
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Login both mweb and Android app
2. Tap on expensify selector
3. Tap plus icon to create new workspace

Expected Result:

Creating workspace via plus icon must not show inconsistent behavior in mweb and Android

Actual Result:

Creating workspace via plus icon directs to workspace list page briefly before directing to workspace page in mweb. In Android, LHN shown briefly before directing to workspace page. Creating workspace via plus icon shows inconsistent behavior in mweb and Android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554877_1722102546869.srlector.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ada2399e173f08f
• Upwork Job ID: 1818305792283231533
• Last Price Increase: 2024-07-30
• Automatic offers:
• huult | Contributor | 103365224

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016ada2399e173f08f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Creating workspace via plus icon shows inconsistent behavior in mweb and Android

What is the root cause of that problem?

Web Behavior:

• Home -> LeftModalNavigator -> Click on Plus Icon -> Workspace

Android Native:

• Home -> LeftModalNavigator -> Click on Plus Icon -> Home -> Workspace

Web browsers might skip intermediate screens due to history optimization, while Android native apps with React Navigation manage each transition explicitly without skipping.

App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

Lines 35 to 38 in d69b203

	onPress={() => {
	Navigation.goBack();
	interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt());
	}}

What changes do you think we should make in order to solve the problem?

To ensure consistent behavior between the web browser and native app, we should redirect directly to the Workspace.
Here is my update:

// src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx#L35
                     onPress={() => {
-                        Navigation.goBack();
                         interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt());
                    }}

POC

Screen.Recording.2024-08-01.at.23.39.37.mp4

[jayeshmangwani]

@huult Thanks for the proposal. Could you please explain why we need to pass transitionFromOldDot as true in the createWorkspaceWithPolicyDraftAndNavigateToIt method? Will the current call to createWorkspaceWithPolicyDraftAndNavigateToIt cause any issues?

[huult]

Proposal updated

• Update code changes
• Update POC

Hi @jayeshmangwani, After double-checking, it looks like simply removing goBack is enough to fix the issue. Thanks!

[jayeshmangwani]

@huult's Proposal looks good to me.

We can remove the Navigation.goBack() from onPress, as it was added to solve this issue #35680 and removing it will not cause the issue to reoccur. I've tested it, so we're good to proceed with the goBack removal

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @huult 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[huult]

Here is my PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix inconsistent workspace creation #46699

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @huult requires payment automatic offer (Contributor)
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR AUG 14, if no regressions

• Fix: @huult [$250] offer
• PR Review: @jayeshmangwani [$250] payment via NewDot
  Please complete checklist

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Fix workspace switcher creating new workspace #36162
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix workspace switcher creating new workspace #36162 (comment)
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Log in to both the mobile web (mWeb) and Android app.
2. Tap on the Expensify selector.
3. Tap the plus icon to create a new workspace.
4. The LHN should not be briefly shown before directing to the workspace page

Do we agree 👍 or 👎

[abekkala]

@huult payment sent and contract ended - thank you! 🎉

[abekkala]

@jayeshmangwani [$250] payment via NewDot

[jayeshmangwani]

Requested on ND as per #46383 (comment)

[JmillsExpensify]

$250 approved for @jayeshmangwani